Skip to content

refactor(query-orchestrator): Local queue driver - handle processing … #9706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 25, 2025

Conversation

ovr
Copy link
Member

@ovr ovr commented Jun 24, 2025

In this PR, I did a refactor for the LocalQueue driver. Previously, while the LocalQueue driver processed the queue item, it stored it in the pending and active states. Both states at the same time. This approach is not aligned with any queue servers.

Cube Store has a strict obligation that a queue item can be in only one state at a time. Let's align it to simplify upcoming changes in #9705.

Thanks

@ovr ovr force-pushed the refactor/queue-memory-driver-handle-active branch from 8f11893 to d14e5c6 Compare June 25, 2025 10:44
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM

@ovr ovr merged commit 2d66576 into master Jun 25, 2025
67 checks passed
@ovr ovr deleted the refactor/queue-memory-driver-handle-active branch June 25, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants