Skip to content

feat(FilterListBox): add component #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 70 commits into from
Jul 24, 2025
Merged

feat(FilterListBox): add component #730

merged 70 commits into from
Jul 24, 2025

Conversation

tenphi
Copy link
Member

@tenphi tenphi commented Jul 18, 2025

No description provided.

Copy link

changeset-bot bot commented Jul 18, 2025

🦋 Changeset detected

Latest commit: b2071f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-dev/ui-kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cube-ui-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2025 4:26pm
cube-ui-kit-cursor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2025 4:26pm

Copy link
Contributor

github-actions bot commented Jul 18, 2025

📦 NPM canary release

Deployed canary version 0.0.0-canary-75bb329.

Copy link
Contributor

github-actions bot commented Jul 18, 2025

🏋️ Size limit report

Name Size Passed?
All 272.24 KB (+3.8% 🔺) Yes 🎉
Tree shaking (just a Button) 21.76 KB (+0.18% 🔺) Yes 🎉
Tree shaking (just an Icon) 11.41 KB (0% 🟰) Yes 🎉

Click here if you want to find out what is changed in this build

Copy link
Contributor

github-actions bot commented Jul 18, 2025

🧪 Storybook is successfully deployed!

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Enter Key Triggers Incorrect Callback

The FilterListBox's Enter key handler incorrectly calls the onEscape() callback when an item is selected in a checkable, multiple-selection list. This is counterintuitive and can lead to unexpected parent dialog closure instead of just item selection.

src/components/fields/FilterListBox/FilterListBox.tsx#L680-L688

if (
e.key === 'Enter' &&
isCheckable &&
onEscape &&
selectionMode === 'multiple'
) {
onEscape();
}

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

@tenphi tenphi merged commit 5d627ef into main Jul 24, 2025
14 checks passed
@tenphi tenphi deleted the feat-filter-picker branch July 24, 2025 09:58
@github-actions github-actions bot mentioned this pull request Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant