-
Notifications
You must be signed in to change notification settings - Fork 6
feat(FilterListBox): add component #730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: b2071f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 NPM canary releaseDeployed canary version 0.0.0-canary-75bb329. |
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
🧪 Storybook is successfully deployed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Enter Key Triggers Incorrect Callback
The FilterListBox
's Enter key handler incorrectly calls the onEscape()
callback when an item is selected in a checkable, multiple-selection list. This is counterintuitive and can lead to unexpected parent dialog closure instead of just item selection.
src/components/fields/FilterListBox/FilterListBox.tsx#L680-L688
cube-ui-kit/src/components/fields/FilterListBox/FilterListBox.tsx
Lines 680 to 688 in b2071f3
if ( | |
e.key === 'Enter' && | |
isCheckable && | |
onEscape && | |
selectionMode === 'multiple' | |
) { | |
onEscape(); | |
} |
Was this report helpful? Give feedback by reacting with 👍 or 👎
No description provided.