-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Enable credentials auth #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis pull request updates the Helm chart version for the Changes
Sequence Diagram(s)sequenceDiagram
participant GlobalConfig as Global Config (values.yaml)
participant Deployment as Deployment Template (deployment.yaml)
participant Container as Running Container
GlobalConfig->>Deployment: Provide credentials.enabled value ("true"/"false"/"auto")
Deployment->>Container: Set AUTH_CREDENTIALS_ENABLED accordingly
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
charts/ctrlplane/Chart.yaml (1)
5-5
: Version Bump Updated Successfully
The chart version has been correctly updated from0.3.9
to0.3.10
. Ensure that this change is reflected in any accompanying release notes or changelogs for consistency.charts/ctrlplane/values.yaml (1)
15-16
: New Credentials Configuration Added
The new configuration block for credentials (withenabled: "auto"
) has been added underglobal.authProviders
. This aligns with the intended design for dynamic authentication setup. Consider updating documentation (e.g., README or values file comments) to clarify the allowed values ("true"
,"false"
, and"auto"
) for future maintainers.charts/ctrlplane/charts/webservice/templates/deployment.yaml (1)
73-82
: Conditional Injection of AUTH_CREDENTIALS_ENABLED is Clear
The new environment variableAUTH_CREDENTIALS_ENABLED
is conditionally set based on the value of.Values.global.authProviders.credentials.enabled
:
- When
"true"
, it is set to"true"
.- When
"false"
, it is set to"false"
.- Otherwise, it defaults to
"auto"
.This implementation is clear and covers all expected cases. Consider adding an inline comment in the template to document the expected values and behavior for improved maintainability.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
charts/ctrlplane/Chart.yaml
(1 hunks)charts/ctrlplane/charts/webservice/templates/deployment.yaml
(1 hunks)charts/ctrlplane/values.yaml
(1 hunks)
Summary by CodeRabbit
Chores
New Features