Adds extra fields per #17 #18
Merged
+37
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ma11hewThomas
approved these changes
Aug 2, 2025
|
Thank you! |
Pull Request Test Coverage Report for Build 16637058440Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the changes proposed in #17.
Based off my reading of the spec, it seems that it just needs the fields added as part of
NewReport, but if that's not the case please let me know.The timestamp is stored internally as a
time.Time. For unmarshaling and marshaling, this will use RFC3339, which is approximately equivalent to ISO8601 (although with some notable differences).Thanks!