created donors table, added routes, updated the backend, and created … #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a component for donation filter
Co-authored-by: Arnav Kanekar <arnavk377@users.noreply.github.com>
…ithub.com/ctc-uci/cch into 140-donations-styling-functionality-CK-AK
Closed
Co-authored-by: Colin Kwon <Cobby914@users.noreply.github.com>
…to 142-update-donors
Co-authored-by: Colin Kwon <Cobby914@users.noreply.github.com>
filter and search changes
srukelman
requested changes
Apr 28, 2025
Collaborator
srukelman
left a comment
srukelman
left a comment
There was a problem hiding this comment.
hey guys this looks good so far the only issue i saw was the post and put requests not working for editing and creating donations. i fixed the post for ygs, so all u should need to fix is the PUT. also when i go to add a donation there are no donors in the dropdown
also the date input on the add donation isn't working for me if ygs could fix that as well
server/routes/donations.ts
Outdated
Comment on lines
368
to
376
| const donor_id = await db.query( | ||
| `SELECT id FROM donors WHERE name = $1`, | ||
| [donor] | ||
| ); | ||
| const data = await db.query( | ||
| `UPDATE donations SET date = COALESCE($1, date),weight = COALESCE($2, weight),value = COALESCE($3, value), | ||
| donor = COALESCE($4, donor), category = COALESCE($5, category) WHERE id = $6 RETURNING id`, | ||
| [date, weight, value, donor, category, id] | ||
| donor_id = COALESCE($4, donor_id), category = COALESCE($5, category) WHERE id = $6 RETURNING id`, | ||
| [date, weight, value, donor_id, category, id] | ||
| ); |
Collaborator
There was a problem hiding this comment.
i think this doesn't work. take a look at how i wrote this for the post request on line 343. the problem is that the await for the donor doesn't finish getting retrieved from the db so it's undefined in the second call
Co-authored-by: Colin Kwon <Cobby914@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…a component for donation filter
Description
Screenshots/Media
Issues
Closes #