[FIX] Make --detach argument explicit to handle future Docker Swarm changes #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Since --detach=false was not specified, tasks will be created in the background. In a future release, --detach=false will become the default.
Docker Swarm will set --detach argument to false in the future, which will break the code unless specified explicitly. I've added another if block to set this argument to true. This will also remove the warning in the logs.
Checklist