Skip to content

DBA-718 Added bind parameter replacement for explain plans. #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 4, 2025
Merged

DBA-718 Added bind parameter replacement for explain plans. #25

merged 7 commits into from
Apr 4, 2025

Conversation

mdashti
Copy link
Contributor

@mdashti mdashti commented Apr 4, 2025

No description provided.

@mdashti mdashti requested review from jssmith and greglearns April 4, 2025 06:53
@mdashti mdashti requested review from rahulcap and removed request for rahulcap April 4, 2025 08:55
@mdashti mdashti changed the title DBA-718 Added parameter replacement for generic explain plans. DBA-718 Added bind parameter replacement for explain plans. Apr 4, 2025
@mdashti mdashti self-assigned this Apr 4, 2025
jssmith
jssmith approved these changes Apr 4, 2025
View reviewed changes
Copy link
Contributor

@jssmith jssmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Questions:

  • Should we add Docker-based tests with various PG versions?
  • Should we compare how our parameter replacement does relative to generic explain plans in v16+?

@mdashti mdashti merged commit 2fb3ab6 into main Apr 4, 2025
1 check passed
@mdashti mdashti deleted the mdashti/DBA-718-explain-tool4 branch April 4, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jssmith jssmith jssmith approved these changes

@greglearns greglearns Awaiting requested review from greglearns

Assignees

@mdashti mdashti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdashti @jssmith