Use firstword instead of lastword to locate current Makefile path #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `include` lines are used in Makefile, the newly included Makefile path will be appended to MAKEFILE_LIST. And using `lastword` to fetch current Makefile path would fail. This change alter the code to use firstword so as to fetch the top level Makefile path.
XuJiandong
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
includelines are used in Makefile, the newly included Makefile path will be appended to MAKEFILE_LIST. And usinglastwordto fetch current Makefile path would fail. This change alter the code to use firstword so as to fetch the top level Makefile path.