Skip to content

Fix namespaced models foreign key #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Fix namespaced models foreign key #460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e3728fe
First draft
andreaslillebo Oct 10, 2025
631daa1
Remove unnecessary comments
andreaslillebo Oct 10, 2025
c2a1af6
Better match
andreaslillebo Oct 10, 2025
d21faf7
Reproduce bug execatly
andreaslillebo Oct 10, 2025
189890d
Fix typo
andreaslillebo Oct 10, 2025
3ec6443
Rubocop
andreaslillebo Oct 10, 2025
34b4322
Handle foreign keys correctly
andreaslillebo Oct 10, 2025
362b470
Fix foreign_key values
andreaslillebo Oct 10, 2025
a3da736
Simplify
andreaslillebo Oct 10, 2025
5f3aecb
Refactor
andreaslillebo Oct 10, 2025
4a2a30c
Linting
andreaslillebo Oct 10, 2025
92e4b1e
Linting
andreaslillebo Oct 10, 2025
1240926
Remove old comment
andreaslillebo Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 21 additions & 14 deletions gemfiles/rails_7.1.gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,15 +98,15 @@ GEM
rake
thor (>= 0.14.0)
ast (2.4.3)
async (2.32.0)
async (2.34.0)
console (~> 1.29)
fiber-annotation
io-event (~> 1.11)
metrics (~> 0.12)
traces (~> 0.18)
base64 (0.3.0)
benchmark (0.4.1)
bigdecimal (3.2.3)
bigdecimal (3.3.1)
builder (3.3.0)
childprocess (5.1.0)
logger (~> 1.5)
Expand All @@ -129,10 +129,10 @@ GEM
docile (1.4.1)
dotenv (3.1.8)
drb (2.2.3)
erb (5.0.2)
erb (5.0.3)
erubi (1.13.1)
event_stream_parser (1.0.0)
faraday (2.13.4)
faraday (2.14.0)
faraday-net_http (>= 2.0, < 3.5)
json
logger
Expand All @@ -148,6 +148,7 @@ GEM
concurrent-ruby (~> 1.1)
webrick (~> 1.7)
websocket-driver (~> 0.7)
ffi (1.17.2-arm64-darwin)
ffi (1.17.2-x86_64-linux-gnu)
fiber-annotation (0.2.0)
fiber-local (1.1.0)
Expand Down Expand Up @@ -185,7 +186,7 @@ GEM
pp (>= 0.6.0)
rdoc (>= 4.0.0)
reline (>= 0.4.2)
json (2.15.0)
json (2.15.1)
json-schema (6.0.0)
addressable (~> 2.8)
bigdecimal (~> 3.1)
Expand All @@ -208,13 +209,13 @@ GEM
mini_magick (5.3.1)
logger
mini_mime (1.1.5)
minitest (5.25.5)
minitest (5.26.0)
multi_json (1.17.0)
multipart-post (2.4.1)
mutex_m (0.3.0)
net-http (0.6.0)
uri
net-imap (0.5.10)
net-imap (0.5.12)
date
net-protocol
net-pop (0.1.2)
Expand All @@ -224,6 +225,8 @@ GEM
net-smtp (0.5.1)
net-protocol
nio4r (2.7.4)
nokogiri (1.18.10-arm64-darwin)
racc (~> 1.4)
nokogiri (1.18.10-x86_64-linux-gnu)
racc (~> 1.4)
os (1.1.4)
Expand All @@ -236,10 +239,10 @@ GEM
ast (~> 2.4.1)
racc
path_expander (1.1.3)
pp (0.6.2)
pp (0.6.3)
prettyprint
prettyprint (0.2.0)
prism (1.5.1)
prism (1.5.2)
pry (0.15.2)
coderay (~> 1.1)
method_source (~> 1.0)
Expand All @@ -248,7 +251,7 @@ GEM
stringio
public_suffix (6.0.2)
racc (1.8.1)
rack (3.2.1)
rack (3.2.3)
rack-session (2.1.1)
base64 (>= 0.1.0)
rack (>= 3.0.0)
Expand Down Expand Up @@ -287,9 +290,10 @@ GEM
zeitwerk (~> 2.6)
rainbow (3.1.1)
rake (13.3.0)
rdoc (6.14.2)
rdoc (6.15.0)
erb
psych (>= 4.0.0)
tsort
regexp_parser (2.11.3)
reline (0.6.2)
io-console (~> 0.5)
Expand All @@ -307,7 +311,7 @@ GEM
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.13.0)
rspec-support (3.13.6)
rubocop (1.81.0)
rubocop (1.81.1)
json (~> 2.3)
language_server-protocol (~> 3.17.0.2)
lint_roller (~> 1.1.0)
Expand Down Expand Up @@ -355,17 +359,19 @@ GEM
simplecov (~> 0.19)
simplecov-html (0.13.2)
simplecov_json_formatter (0.1.4)
sqlite3 (2.7.4-arm64-darwin)
sqlite3 (2.7.4-x86_64-linux-gnu)
stringio (3.1.7)
thor (1.4.0)
timeout (0.4.3)
traces (0.18.2)
tsort (0.2.0)
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
unicode-display_width (3.2.0)
unicode-emoji (~> 4.1)
unicode-emoji (4.1.0)
uri (1.0.3)
uri (1.0.4)
vcr (6.3.1)
base64
webmock (3.25.1)
Expand All @@ -380,6 +386,7 @@ GEM
zeitwerk (2.7.3)

PLATFORMS
arm64-darwin-24
x86_64-linux

DEPENDENCIES
Expand Down Expand Up @@ -416,4 +423,4 @@ DEPENDENCIES
webmock (~> 3.18)

BUNDLED WITH
2.6.9
2.7.2
35 changes: 21 additions & 14 deletions gemfiles/rails_7.2.gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,15 +92,15 @@ GEM
rake
thor (>= 0.14.0)
ast (2.4.3)
async (2.32.0)
async (2.34.0)
console (~> 1.29)
fiber-annotation
io-event (~> 1.11)
metrics (~> 0.12)
traces (~> 0.18)
base64 (0.3.0)
benchmark (0.4.1)
bigdecimal (3.2.3)
bigdecimal (3.3.1)
builder (3.3.0)
childprocess (5.1.0)
logger (~> 1.5)
Expand All @@ -123,10 +123,10 @@ GEM
docile (1.4.1)
dotenv (3.1.8)
drb (2.2.3)
erb (5.0.2)
erb (5.0.3)
erubi (1.13.1)
event_stream_parser (1.0.0)
faraday (2.13.4)
faraday (2.14.0)
faraday-net_http (>= 2.0, < 3.5)
json
logger
Expand All @@ -142,6 +142,7 @@ GEM
concurrent-ruby (~> 1.1)
webrick (~> 1.7)
websocket-driver (~> 0.7)
ffi (1.17.2-arm64-darwin)
ffi (1.17.2-x86_64-linux-gnu)
fiber-annotation (0.2.0)
fiber-local (1.1.0)
Expand Down Expand Up @@ -179,7 +180,7 @@ GEM
pp (>= 0.6.0)
rdoc (>= 4.0.0)
reline (>= 0.4.2)
json (2.15.0)
json (2.15.1)
json-schema (6.0.0)
addressable (~> 2.8)
bigdecimal (~> 3.1)
Expand All @@ -202,12 +203,12 @@ GEM
mini_magick (5.3.1)
logger
mini_mime (1.1.5)
minitest (5.25.5)
minitest (5.26.0)
multi_json (1.17.0)
multipart-post (2.4.1)
net-http (0.6.0)
uri
net-imap (0.5.10)
net-imap (0.5.12)
date
net-protocol
net-pop (0.1.2)
Expand All @@ -217,6 +218,8 @@ GEM
net-smtp (0.5.1)
net-protocol
nio4r (2.7.4)
nokogiri (1.18.10-arm64-darwin)
racc (~> 1.4)
nokogiri (1.18.10-x86_64-linux-gnu)
racc (~> 1.4)
os (1.1.4)
Expand All @@ -229,10 +232,10 @@ GEM
ast (~> 2.4.1)
racc
path_expander (1.1.3)
pp (0.6.2)
pp (0.6.3)
prettyprint
prettyprint (0.2.0)
prism (1.5.1)
prism (1.5.2)
pry (0.15.2)
coderay (~> 1.1)
method_source (~> 1.0)
Expand All @@ -241,7 +244,7 @@ GEM
stringio
public_suffix (6.0.2)
racc (1.8.1)
rack (3.1.16)
rack (3.1.18)
rack-session (2.1.1)
base64 (>= 0.1.0)
rack (>= 3.0.0)
Expand Down Expand Up @@ -280,9 +283,10 @@ GEM
zeitwerk (~> 2.6)
rainbow (3.1.1)
rake (13.3.0)
rdoc (6.14.2)
rdoc (6.15.0)
erb
psych (>= 4.0.0)
tsort
regexp_parser (2.11.3)
reline (0.6.2)
io-console (~> 0.5)
Expand All @@ -300,7 +304,7 @@ GEM
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.13.0)
rspec-support (3.13.6)
rubocop (1.81.0)
rubocop (1.81.1)
json (~> 2.3)
language_server-protocol (~> 3.17.0.2)
lint_roller (~> 1.1.0)
Expand Down Expand Up @@ -348,17 +352,19 @@ GEM
simplecov (~> 0.19)
simplecov-html (0.13.2)
simplecov_json_formatter (0.1.4)
sqlite3 (2.7.4-arm64-darwin)
sqlite3 (2.7.4-x86_64-linux-gnu)
stringio (3.1.7)
thor (1.4.0)
timeout (0.4.3)
traces (0.18.2)
tsort (0.2.0)
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
unicode-display_width (3.2.0)
unicode-emoji (~> 4.1)
unicode-emoji (4.1.0)
uri (1.0.3)
uri (1.0.4)
useragent (0.16.11)
vcr (6.3.1)
base64
Expand All @@ -374,6 +380,7 @@ GEM
zeitwerk (2.7.3)

PLATFORMS
arm64-darwin-24
x86_64-linux

DEPENDENCIES
Expand Down Expand Up @@ -410,4 +417,4 @@ DEPENDENCIES
webmock (~> 3.18)

BUNDLED WITH
2.6.9
2.7.2
Loading