-
-
Notifications
You must be signed in to change notification settings - Fork 191
Add Azure OpenAI provider #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hola @crmne. Before I go further, can you please take a look and let me know if I'm on the right track? I had to overload some methods to "steal" model ID and config properties because of the way Azure OpenAI API URLs get constructed using model and API version. |
@crmne, apologies if I am pestering you. I've been using the new provider with my project where I have tested I don't fully understand how / what I should do for the RSpec tests. Let me know how you would like me to proceed, or if you are comfortable with accepting this PR as is. |
Hi @oxaroky02 just add your models to the correct lists in |
@crmne I've configured |
Hmm, looks like I need to figure out the Postgres config for the commit hooks to work. OK, no worries, I'll work on that. |
@oxaroky02 what errors are you getting with PG? I may be able to help. This PR is necessary for us to utilize RubyLLM without patching. |
@oxaroky02 also, could we add a config for always assuming model exists? With Azure we have many models names and would love to just use the standard |
I tried running |
@oxaroky02 do you have a Mac? If so, simplest way to get PG running is installing https://postgresapp.com/. It'll give you what you need and then you can remove if you don't need it anymore. |
@t2, I have
I'm getting following exception:
I see the spec helper is loading a Questions:
I appreciate your patience and support with this. |
I'm not extremely familiar with Docker so I don't think I could help there. If you just install Postgress.app on your main computer I expect it should just work. |
@t2, no worries, I'll keep looking. I'm limited with what I can install on my work laptop. The DB is up and running and I'm able to connect to it etc. So now I'm trying to figure out where exactly the password can be specified for the tests to run. Were you able to try the new provider tho? Did it work for you? I'll look into your other question soon, I'm still figuring out how the innards of |
Looks like I can set the default for |
I just checked out your branch and tested and IT WORKED 🤘🏼! Once you get past the tests this will be great for the folks on Azure OpenAI. |
DELETING (I figured out the problem. There was something going on with the default |
07ffcf8
to
9b98721
Compare
The tests are running properly now. I have added models listing support now and I've updated @crmne, when I run the rake task it ends up making a lot of changes to the One thing I can do (which I tried for fun) is take the new entry and stuff it into the original BUT this kinda goes against the constraint that I shouldn't modify the file manually. How would you like me to proceed? |
What this does
Adds Azure OpenAI provider, derived from the existing OpenAI provider.
Provider can be configured as follows:
Type of change
Scope check
Quality check
overcommit --install
and all hooks passmodels.json
,aliases.json
)API changes
Related issues