Add specs for model filtering and chat functionalities

Author: crmne

spec/ruby_llm/chat_functions_spec.rb

@@ -0,0 +1,79 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'dotenv/load'
+
+RSpec.describe RubyLLM::Chat do
+  include_context 'with configured RubyLLM'
+
+  describe '#with_tool unsupported functions' do
+    it "raises UnsupportedFunctionsError when model doesn't support functions" do # rubocop:disable RSpec/ExampleLength
+      # Create a non-function-calling model by patching the supports_functions attribute
+      model = RubyLLM.models.find('gpt-4o-mini')
+      allow(model).to receive(:supports_functions).and_return(false)
+
+      chat = described_class.new(model: 'gpt-4o-mini')
+      # Replace the model with our modified version
+      chat.instance_variable_set(:@model, model)
+
+      expect do
+        chat.with_tool(RubyLLM::Tool)
+      end.to raise_error(RubyLLM::UnsupportedFunctionsError, /doesn't support function calling/)
+    end
+  end
+
+  describe '#with_tools' do
+    it 'adds multiple tools at once' do # rubocop:disable RSpec/ExampleLength,RSpec/MultipleExpectations
+      chat = described_class.new
+
+      tool1 = Class.new(RubyLLM::Tool) do
+        def name = 'tool1'
+      end
+
+      tool2 = Class.new(RubyLLM::Tool) do
+        def name = 'tool2'
+      end
+
+      chat.with_tools(tool1.new, tool2.new)
+
+      expect(chat.tools.keys).to include(:tool1, :tool2)
+      expect(chat.tools.size).to eq(2)
+    end
+  end
+
+  describe '#with_model' do
+    it 'changes the model and returns self' do # rubocop:disable RSpec/MultipleExpectations
+      chat = described_class.new(model: 'gpt-4o-mini')
+      result = chat.with_model('claude-3-5-haiku-20241022')
+
+      expect(chat.model.id).to eq('claude-3-5-haiku-20241022')
+      expect(result).to eq(chat) # Should return self for chaining
+    end
+  end
+
+  describe '#with_temperature' do
+    it 'sets the temperature and returns self' do # rubocop:disable RSpec/MultipleExpectations
+      chat = described_class.new
+      result = chat.with_temperature(0.8)
+
+      expect(chat.instance_variable_get(:@temperature)).to eq(0.8)
+      expect(result).to eq(chat) # Should return self for chaining
+    end
+  end
+
+  describe '#each' do
+    it 'iterates through messages' do # rubocop:disable RSpec/ExampleLength,RSpec/MultipleExpectations
+      chat = described_class.new
+      chat.add_message(role: :user, content: 'Message 1')
+      chat.add_message(role: :assistant, content: 'Message 2')
+
+      messages = chat.map do |msg|
+        msg
+      end
+
+      expect(messages.size).to eq(2)
+      expect(messages[0].content).to eq('Message 1')
+      expect(messages[1].content).to eq('Message 2')
+    end
+  end
+end

spec/ruby_llm/models_spec.rb

@@ -101,4 +101,65 @@
       end
     end
   end
+
+  describe '#embedding_models' do
+    it 'filters to only embedding models' do # rubocop:disable RSpec/MultipleExpectations
+      embedding_models = RubyLLM.models.embedding_models
+
+      expect(embedding_models).to be_a(described_class)
+      expect(embedding_models.all).to all(have_attributes(type: 'embedding'))
+      expect(embedding_models.all).not_to be_empty
+    end
+  end
+
+  describe '#audio_models' do
+    it 'filters to only audio models' do # rubocop:disable RSpec/MultipleExpectations
+      audio_models = RubyLLM.models.audio_models
+
+      expect(audio_models).to be_a(described_class)
+      expect(audio_models.all).to all(have_attributes(type: 'audio'))
+    end
+  end
+
+  describe '#image_models' do
+    it 'filters to only image models' do # rubocop:disable RSpec/MultipleExpectations
+      image_models = RubyLLM.models.image_models
+
+      expect(image_models).to be_a(described_class)
+      expect(image_models.all).to all(have_attributes(type: 'image'))
+      expect(image_models.all).not_to be_empty
+    end
+  end
+
+  describe '#by_family' do
+    it 'filters models by family' do # rubocop:disable RSpec/MultipleExpectations
+      # Use a family we know exists
+      family = RubyLLM.models.all.first.family
+      family_models = RubyLLM.models.by_family(family)
+
+      expect(family_models).to be_a(described_class)
+      expect(family_models.all).to all(have_attributes(family: family))
+      expect(family_models.all).not_to be_empty
+    end
+  end
+
+  describe '#save_models' do
+    it 'saves models to the models.json file' do # rubocop:disable RSpec/ExampleLength,RSpec/MultipleExpectations
+      temp_file = Tempfile.new(['models', '.json'])
+      allow(described_class).to receive(:models_file).and_return(temp_file.path)
+
+      models = RubyLLM.models
+      models.save_models
+
+      # Verify file was written with valid JSON
+      saved_content = File.read(temp_file.path)
+      expect { JSON.parse(saved_content) }.not_to raise_error
+
+      # Verify model data was saved
+      parsed_models = JSON.parse(saved_content)
+      expect(parsed_models.size).to eq(models.all.size)
+
+      temp_file.unlink
+    end
+  end
 end

spec/ruby_llm/providers/openai/capabilities_spec.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'dotenv/load'
+
+RSpec.describe RubyLLM::Providers::OpenAI::Capabilities do # rubocop:disable RSpec/SpecFilePathFormat
+  describe '.normalize_temperature' do
+    it 'forces temperature to 1.0 for O1 models' do
+      o1_models = %w[o1 o1-mini o1-preview o3-mini]
+
+      o1_models.each do |model|
+        result = described_class.normalize_temperature(0.7, model)
+        expect(result).to eq(1.0)
+      end
+    end
+
+    it 'preserves temperature for non-O1 models' do
+      non_o1_models = ['gpt-4', 'gpt-4o', 'claude-3-opus']
+
+      non_o1_models.each do |model|
+        result = described_class.normalize_temperature(0.7, model)
+        expect(result).to eq(0.7)
+      end
+    end
+  end
+end