Normalize temperature for o1 and o3 models

Author: crmne

lib/ruby_llm/chat.rb

@@ -16,7 +16,7 @@ class Chat
     def initialize(model: nil)
       model_id = model || RubyLLM.config.default_model
       self.model = model_id
-      @temperature = @model.metadata['family'] == 'o1' ? 1 : 0.7
+      @temperature = 0.7
       @messages = []
       @tools = {}
       @on = {

lib/ruby_llm/provider.rb

@@ -8,8 +8,18 @@ module Provider
     # Common functionality for all LLM providers. Implements the core provider
     # interface so specific providers only need to implement a few key methods.
     module Methods # rubocop:disable Metrics/ModuleLength
-      def complete(messages, tools:, temperature:, model:, &block)
-        payload = render_payload messages, tools: tools, temperature: temperature, model: model, stream: block_given?
+      def complete(messages, tools:, temperature:, model:, &block) # rubocop:disable Metrics/MethodLength
+        normalized_temperature = if capabilities.respond_to?(:normalize_temperature)
+                                   capabilities.normalize_temperature(temperature, model)
+                                 else
+                                   temperature
+                                 end
+
+        payload = render_payload(messages,
+                                 tools: tools,
+                                 temperature: normalized_temperature,
+                                 model: model,
+                                 stream: block_given?)
 
         if block_given?
           stream_response payload, &block

lib/ruby_llm/providers/openai/capabilities.rb

@@ -257,6 +257,16 @@ def apply_special_formatting(name) # rubocop:disable Metrics/MethodLength
             .gsub('Omni Moderation', 'Omni-Moderation')
             .gsub('Text Moderation', 'Text-Moderation')
         end
+
+        def normalize_temperature(temperature, model_id)
+          if model_id.match?(/o[13]/)
+            # O1/O3 models always use temperature 1.0
+            RubyLLM.logger.debug "Model #{model_id} requires temperature=1.0, ignoring provided value"
+            1.0
+          else
+            temperature
+          end
+        end
       end
     end
   end