feature: upgrade typescript-eslint and node packages to latest versions #1504
+289
−13
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| module.exports = { | ||
| parser: '@typescript-eslint/parser', | ||
| parserOptions: { | ||
| project: 'tsconfig.json', | ||
| sourceType: 'module' | ||
| }, | ||
| plugins: ['@typescript-eslint/eslint-plugin'], | ||
| extends: ['plugin:@typescript-eslint/recommended', 'plugin:prettier/recommended'], | ||
| root: true, | ||
| env: { | ||
| node: true, | ||
| jest: true | ||
| }, | ||
| ignorePatterns: ['.eslintrc.js'], | ||
| rules: { | ||
| 'prettier/prettier': 0, | ||
| 'no-console': 'error', | ||
| // "@typescript-eslint/consistent-type-imports": "error", | ||
| '@typescript-eslint/no-unused-vars': [ | ||
| 'error' | ||
| // { | ||
| // "argsIgnorePattern": "_" | ||
| // } | ||
| ], | ||
| '@typescript-eslint/array-type': 'error', | ||
| 'template-curly-spacing': 'error', | ||
| '@typescript-eslint/explicit-function-return-type': 'error', | ||
| '@typescript-eslint/explicit-module-boundary-types': 'warn', | ||
| '@typescript-eslint/no-explicit-any': 'error', | ||
| '@typescript-eslint/no-use-before-define': 'error', | ||
| complexity: ['error', 50], | ||
| 'array-callback-return': 'error', | ||
| curly: 'error', | ||
| 'default-case': 'error', | ||
| 'default-case-last': 'error', | ||
| 'default-param-last': 'error', | ||
| camelcase: [2, { properties: 'always' }], | ||
| 'no-invalid-this': 'error', | ||
| 'no-return-assign': 'error', | ||
| 'no-unused-expressions': ['error', { allowTernary: true }], | ||
| 'no-useless-concat': 'error', | ||
| 'no-useless-return': 'error', | ||
| 'guard-for-in': 'error', | ||
| 'no-case-declarations': 'error', | ||
| 'no-implicit-coercion': 'error', | ||
| 'no-lone-blocks': 'error', | ||
| 'no-loop-func': 'error', | ||
| 'no-param-reassign': 'error', | ||
| 'no-return-await': 'error', | ||
| 'no-self-compare': 'error', | ||
| 'no-throw-literal': 'error', | ||
| 'no-useless-catch': 'error', | ||
| 'prefer-promise-reject-errors': 'error', | ||
| 'vars-on-top': 'error', | ||
| yoda: ['error', 'always'], | ||
| 'arrow-body-style': ['warn', 'as-needed'], | ||
| 'no-useless-rename': 'error', | ||
| 'prefer-destructuring': [ | ||
| 'error', | ||
| { | ||
| array: true, | ||
| object: true | ||
| }, | ||
| { | ||
| enforceForRenamedProperties: false | ||
| } | ||
| ], | ||
| 'prefer-numeric-literals': 'error', | ||
| 'prefer-rest-params': 'warn', | ||
| 'prefer-spread': 'error', | ||
| 'array-bracket-newline': ['error', { multiline: true, minItems: null }], | ||
| 'array-bracket-spacing': 'error', | ||
| 'brace-style': ['error', '1tbs', { allowSingleLine: true }], | ||
| 'block-spacing': 'error', | ||
| 'comma-dangle': 'error', | ||
| 'comma-spacing': 'error', | ||
| 'comma-style': 'error', | ||
| 'computed-property-spacing': 'error', | ||
| 'func-call-spacing': 'error', | ||
| 'implicit-arrow-linebreak': ['error', 'beside'], | ||
| 'keyword-spacing': 'error', | ||
| 'multiline-ternary': ['error', 'always-multiline'], | ||
| 'no-mixed-operators': 'error', | ||
| 'no-multiple-empty-lines': ['error', { max: 2, maxEOF: 1 }], | ||
| 'no-tabs': 'error', | ||
| 'no-unneeded-ternary': 'error', | ||
| 'no-whitespace-before-property': 'error', | ||
| 'nonblock-statement-body-position': ['error', 'below'], | ||
| 'object-property-newline': ['error', { allowAllPropertiesOnSameLine: true }], | ||
| semi: ['error', 'always'], | ||
| 'semi-spacing': 'error', | ||
| 'space-before-blocks': 'error', | ||
| 'space-in-parens': 'error', | ||
| 'space-infix-ops': 'error', | ||
| 'space-unary-ops': 'error', | ||
| 'arrow-spacing': 'error', | ||
| 'no-confusing-arrow': 'off', | ||
| 'no-var': 'error', | ||
| 'object-shorthand': 'error', | ||
| 'prefer-const': 'error', | ||
| 'prefer-template': 'error', | ||
| quotes: ['warn', 'single', { allowTemplateLiterals: true }] | ||
| } | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| # ESLint Migration Guide | ||
|
|
||
| ## Changes Made | ||
|
|
||
| This migration upgrades the project from ESLint v8 with legacy configuration to ESLint v9 with flat configuration format. | ||
|
|
||
| ### Package Updates | ||
|
|
||
| - `@typescript-eslint/eslint-plugin`: `^6.2.1` → `^8.14.0` | ||
| - `@typescript-eslint/parser`: `^6.2.1` → `^8.14.0` | ||
| - `eslint`: `^8.46.0` → `^9.14.0` | ||
| - `@types/node`: `^20.4.6` → `^22.9.0` | ||
| - `typescript`: `^5.1.6` → `^5.6.3` | ||
| - `prettier`: `^3.0.1` → `^3.3.3` | ||
| - `eslint-config-prettier`: `^8.10.0` → `^9.1.0` | ||
| - `eslint-plugin-prettier`: `^4.2.1` → `^5.2.1` | ||
| - `eslint-plugin-promise`: `^6.1.1` → `^7.1.0` | ||
|
|
||
| ### New Dependencies | ||
|
|
||
| - `@eslint/js`: `^9.14.0` (required for flat config) | ||
|
|
||
| ### Removed Dependencies | ||
|
|
||
| - `eslint-config-standard-with-typescript`: No longer needed with flat config | ||
| - `eslint-plugin-import`: Functionality integrated into core ESLint | ||
| - `eslint-plugin-n`: Not required for this project setup | ||
|
|
||
| ### Configuration Changes | ||
|
|
||
| - **Old**: `.eslintrc.js` (legacy format) | ||
| - **New**: `eslint.config.js` (flat config format) | ||
|
|
||
| The new configuration maintains all existing rules while using the modern flat config structure. | ||
|
|
||
| ### Node.js Version | ||
|
|
||
| - Updated minimum Node.js version from `>=18` to `>=20` (current LTS) | ||
|
|
||
| ## Migration Steps for Developers | ||
|
|
||
| 1. Install dependencies: `pnpm install` | ||
| 2. The old `.eslintrc.js` is backed up as `.eslintrc.js.backup` | ||
| 3. ESLint now uses `eslint.config.js` for configuration | ||
| 4. All existing lint rules are preserved | ||
|
|
||
| ## Verification | ||
|
|
||
| Run the following commands to verify the migration: | ||
|
|
||
| ```bash | ||
| # Check ESLint configuration | ||
| pnpm lint | ||
|
|
||
| # Run tests to ensure no breaking changes | ||
| pnpm test | ||
| ``` | ||
|
|
||
| ## References | ||
|
|
||
| - [ESLint Migration Guide](https://eslint.org/docs/latest/use/configure/migration-guide) | ||
| - [TypeScript ESLint v8 Migration](https://typescript-eslint.io/blog/announcing-typescript-eslint-v8-beta/) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,112 @@ | ||||||
| import js from '@eslint/js'; | ||||||
| import tseslint from '@typescript-eslint/eslint-plugin'; | ||||||
| import tsparser from '@typescript-eslint/parser'; | ||||||
| import prettier from 'eslint-plugin-prettier'; | ||||||
|
|
||||||
| export default [ | ||||||
| js.configs.recommended, | ||||||
| { | ||||||
| files: ['**/*.ts', '**/*.tsx'], | ||||||
| languageOptions: { | ||||||
| parser: tsparser, | ||||||
| parserOptions: { | ||||||
| project: './tsconfig.json', | ||||||
| sourceType: 'module', | ||||||
| }, | ||||||
| globals: { | ||||||
| node: true, | ||||||
| jest: true, | ||||||
| }, | ||||||
| }, | ||||||
| plugins: { | ||||||
| '@typescript-eslint': tseslint, | ||||||
| prettier: prettier, | ||||||
| }, | ||||||
| rules: { | ||||||
| 'prettier/prettier': 0, | ||||||
| 'no-console': 'error', | ||||||
| '@typescript-eslint/no-unused-vars': 'error', | ||||||
| '@typescript-eslint/array-type': 'error', | ||||||
| 'template-curly-spacing': 'error', | ||||||
| '@typescript-eslint/explicit-function-return-type': 'error', | ||||||
| '@typescript-eslint/explicit-module-boundary-types': 'warn', | ||||||
| '@typescript-eslint/no-explicit-any': 'error', | ||||||
| '@typescript-eslint/no-use-before-define': 'error', | ||||||
| complexity: ['error', 50], | ||||||
| 'array-callback-return': 'error', | ||||||
| curly: 'error', | ||||||
| 'default-case': 'error', | ||||||
| 'default-case-last': 'error', | ||||||
| 'default-param-last': 'error', | ||||||
| camelcase: [2, { properties: 'always' }], | ||||||
| 'no-invalid-this': 'error', | ||||||
| 'no-return-assign': 'error', | ||||||
| 'no-unused-expressions': ['error', { allowTernary: true }], | ||||||
| 'no-useless-concat': 'error', | ||||||
| 'no-useless-return': 'error', | ||||||
| 'guard-for-in': 'error', | ||||||
| 'no-case-declarations': 'error', | ||||||
| 'no-implicit-coercion': 'error', | ||||||
| 'no-lone-blocks': 'error', | ||||||
| 'no-loop-func': 'error', | ||||||
| 'no-param-reassign': 'error', | ||||||
| 'no-return-await': 'error', | ||||||
|
There was a problem hiding this comment. Replace deprecated The Apply this diff: - 'no-return-await': 'error',
+ '@typescript-eslint/return-await': 'error',📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| 'no-self-compare': 'error', | ||||||
| 'no-throw-literal': 'error', | ||||||
| 'no-useless-catch': 'error', | ||||||
| 'prefer-promise-reject-errors': 'error', | ||||||
| 'vars-on-top': 'error', | ||||||
| yoda: ['error', 'always'], | ||||||
| 'arrow-body-style': ['warn', 'as-needed'], | ||||||
| 'no-useless-rename': 'error', | ||||||
| 'prefer-destructuring': [ | ||||||
| 'error', | ||||||
| { | ||||||
| array: true, | ||||||
| object: true, | ||||||
| }, | ||||||
| { | ||||||
| enforceForRenamedProperties: false, | ||||||
| }, | ||||||
| ], | ||||||
| 'prefer-numeric-literals': 'error', | ||||||
| 'prefer-rest-params': 'warn', | ||||||
| 'prefer-spread': 'error', | ||||||
| 'array-bracket-newline': ['error', { multiline: true, minItems: null }], | ||||||
| 'array-bracket-spacing': 'error', | ||||||
| 'brace-style': ['error', '1tbs', { allowSingleLine: true }], | ||||||
| 'block-spacing': 'error', | ||||||
| 'comma-dangle': 'error', | ||||||
| 'comma-spacing': 'error', | ||||||
| 'comma-style': 'error', | ||||||
| 'computed-property-spacing': 'error', | ||||||
| 'func-call-spacing': 'error', | ||||||
| 'implicit-arrow-linebreak': ['error', 'beside'], | ||||||
| 'keyword-spacing': 'error', | ||||||
| 'multiline-ternary': ['error', 'always-multiline'], | ||||||
| 'no-mixed-operators': 'error', | ||||||
| 'no-multiple-empty-lines': ['error', { max: 2, maxEOF: 1 }], | ||||||
| 'no-tabs': 'error', | ||||||
| 'no-unneeded-ternary': 'error', | ||||||
| 'no-whitespace-before-property': 'error', | ||||||
| 'nonblock-statement-body-position': ['error', 'below'], | ||||||
| 'object-property-newline': ['error', { allowAllPropertiesOnSameLine: true }], | ||||||
| semi: ['error', 'always'], | ||||||
| 'semi-spacing': 'error', | ||||||
| 'space-before-blocks': 'error', | ||||||
| 'space-in-parens': 'error', | ||||||
| 'space-infix-ops': 'error', | ||||||
| 'space-unary-ops': 'error', | ||||||
| 'arrow-spacing': 'error', | ||||||
| 'no-confusing-arrow': 'off', | ||||||
| 'no-var': 'error', | ||||||
| 'object-shorthand': 'error', | ||||||
| 'prefer-const': 'error', | ||||||
| 'prefer-template': 'error', | ||||||
| quotes: ['warn', 'single', { allowTemplateLiterals: true }], | ||||||
| }, | ||||||
| }, | ||||||
| { | ||||||
| ignores: ['.eslintrc.js', 'dist/**', 'node_modules/**'], | ||||||
| }, | ||||||
| ]; | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical: Incorrect globals syntax for flat config.
The globals are defined incorrectly. In ESLint flat config, globals should use actual global definitions, not boolean values. This won't properly define Node.js and Jest global variables, potentially causing false positives for undefined variables.
Apply this diff to fix the globals definition:
You'll also need to add the
globalspackage to devDependencies:"devDependencies": { "@eslint/js": "^9.14.0", + "globals": "^15.12.0",🤖 Prompt for AI Agents