gvforwarder: Remove ExecStartPre from systemd unit

[cfergeau]

The loop waiting for the network device is redundant with
After=sys-devices-virtual-net-%i.device

Summary by Sourcery

Enhancements:

• Remove redundant ExecStartPre network-wait loop from the gvforwarder systemd unit

[sourcery-ai]

Reviewer's Guide

Simplify the gvforwarder systemd unit by removing the redundant ExecStartPre loop and relying on the existing After=sys-devices-virtual-net-%i.device dependency to ensure the network interface is ready before service start.

File-Level Changes

Change	Details	Files
Remove redundant ExecStartPre directive that waited for the network interface.	Deleted the ExecStartPre shell loop checking ip link show over 10 retries Relied on After=sys-devices-virtual-net-%i.device for interface readiness	createdisk.sh

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign praveenkumar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[praveenkumar]

/retest

[praveenkumar]

/retest

[praveenkumar]

/test e2e-microshift

[praveenkumar]

/test e2e-microshift

[praveenkumar]

/retest

[openshift-ci]

@cfergeau: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-microshift-arm	7e47bde	link	true	/test e2e-microshift-arm
ci/prow/e2e-microshift	7e47bde	link	true	/test e2e-microshift
ci/prow/e2e-snc	7e47bde	link	true	/test e2e-snc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.