{WIP] disable nodeip-configuration service

[praveenkumar]

Summary by Sourcery

Disable the nodeip-configuration service on VMs and remove its ordering constraint from the gvisor-tap-vsock container unit.

Enhancements:

• Disable nodeip-configuration service alongside kubelet during disk creation
• Remove the Before=nodeip-configuration.service directive from the gvisor-tap-vsock container service unit

[sourcery-ai]

Reviewer's Guide

Modify the disk creation script to disable the nodeip-configuration service alongside kubelet and remove its ordering directive from the gvisor-tap-vsock container unit.

File-Level Changes

Change	Details	Files
Disable nodeip-configuration service together with kubelet	Extend systemctl disable command to include nodeip-configuration	createdisk.sh
Remove ordering dependency on nodeip-configuration in container unit	Delete 'Before=nodeip-configuration.service' line from the gvisor-tap-vsock unit template	createdisk.sh

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gbraad for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sourcery-ai]

Hey @praveenkumar - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion (bug_risk): Disabled nodeip-configuration but not stopped it

Run systemctl stop nodeip-configuration or use --now to disable and stop it.

Suggested change

	# Disable kubelet service
	${SSH} core@${VM_IP} -- sudo systemctl disable kubelet
	${SSH} core@${VM_IP} -- sudo systemctl disable kubelet nodeip-configuration
	# Disable and stop kubelet and nodeip-configuration services
	${SSH} core@${VM_IP} -- sudo systemctl disable --now kubelet nodeip-configuration

[cfergeau]

Why? What problem does it solve?

[praveenkumar]

Why? What problem does it solve?

It shouldn't start during boot but start when kubelet service start so that it shouldn't interfere with networking and block tap-vsock to get the IP.

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.