snc: Add logic to create /User top level directory for OCP #1047
Conversation
… from host" This reverts commit a890014. Since OCP moves to consume bootc images for node this is not working anymore, in next commit workable solution is added.
Reviewer's Guide by SourceryThis pull request adds logic to create a custom-os image with the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @praveenkumar - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a rollback mechanism in case the custom-os image deployment fails.
- The
sleep 10command is not ideal; use a more robust method to ensure the MachineConfig is applied before proceeding.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
praveenkumar
force-pushed
the
issue_1041
branch
4 times, most recently
from
6aae6c8 to
9891a44
Compare
|
/retest e2e-snc |
|
@praveenkumar: The Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-snc |
Since OCP now moved to use bootc where top level directory is immutable and `chattr -i /` doesn't work as it worked before so only option is to create a custom-os image and deploy that as part of day-2 operation. More details : crc-org#1041 (comment)
|
@praveenkumar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| machineconfiguration.openshift.io/role: master | ||
| name: custom-image | ||
| spec: | ||
| osImageURL: image-registry.openshift-image-registry.svc:5000/openshift-machine-config-operator/rhcos:latest |
There was a problem hiding this comment.
how much does the it increase the bundle size? and can we later delete the image after machine config pool is updated?
There was a problem hiding this comment.
Yes that's what I am exploring.
There was a problem hiding this comment.
I checked the images if it is stored in bundle after creating the bundle
rhel-coreos sha256:66b5f9d8f1af5acee783db84a25c08338252ff9c276d33e391680168a22f42ee
but it is not available in the bundle.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anjannath The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.19 |
|
@praveenkumar: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-4.18 |
|
@praveenkumar: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@praveenkumar: new pull request created: #1048 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@praveenkumar: new pull request created: #1049 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| unset KUBECONFIG | ||
| RHCOS_IMAGE=$(${OC} adm release info -a ${OPENSHIFT_PULL_SECRET_PATH} ${OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE} --image-for=rhel-coreos) | ||
| cat << EOF > ${INSTALL_DIR}/Containerfile | ||
| FROM scratch |
There was a problem hiding this comment.
you could use ${RHCOS_IMAGE} here, and remove the --from ${RHCOS_IMAGE} arg from podman build.
The shell should be able to expand it to its value.
| # Wait for the cluster again to become stable because of all the patches/changes | ||
| wait_till_cluster_stable | ||
|
|
||
| # This section is used to create a custom-os image which have `/Users` |
There was a problem hiding this comment.
imo this comment is a strong indication that this belongs in a create_custom_os_image helper function.
4 participants
Since OCP now moved to use bootc where top level directory is immutable
and
chattr -i /doesn't work as it worked before so only option is tocreate a custom-os image and deploy that as part of day-2 operation.
More details : #1041 (comment)
Summary by Sourcery
Modify Single Node Cluster (SNC) setup to create a custom OS image with
/Usersdirectory for OCP using bootcNew Features:
/Usersdirectory to address immutable top-level directory limitations in OCPEnhancements:
/UserssymlinkDeployment:
Chores: