Skip to content

Conversation

danivilla9
Copy link
Collaborator

@danivilla9 danivilla9 commented Sep 23, 2024

Fixes issue #313. This PR introduces E2E tests using Playwright

In order to test:
1-Clone the podman-desktop repository
2-Go to podman-desktop folder
3-Execute pnpm install
4-Execute pnpm test:e2e:build
6-Set environment variable executing: export PODMAN_DESKTOP_ARGS="/path/to/podman-desktop"
7-Go to crc-extension folder
8-Execute yarn install
8-Execute yarn test:e2e

*Remember that you have to use the latest version of @podman-desktop/tests-playwright in order to execute the tests

@danivilla9 danivilla9 force-pushed the e2e-test-infrastructure branch 2 times, most recently from 0bb8e15 to 167ab9f Compare September 23, 2024 14:55
Signed-off-by: Daniel Villanueva <davillan@redhat.com>
Signed-off-by: Daniel Villanueva <davillan@redhat.com>
@danivilla9 danivilla9 force-pushed the e2e-test-infrastructure branch from 167ab9f to a80bdfe Compare September 23, 2024 14:58
Signed-off-by: Daniel Villanueva <davillan@redhat.com>
Copy link
Contributor

@dgolovin dgolovin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, but I leave the approval to @odockal.

Description for the PR should be updated:

  1. (2,3,4) should be updates to call pnpm from root of the podman-desktop
  2. use yarn for the extension, because it is not migrated to pnpm yet.

@jeffmaury
Copy link
Collaborator

Can't test it on Windows and seems yarn install and yarn test:e2e are enough at the root of the repo

@odockal
Copy link
Collaborator

odockal commented Sep 24, 2024

@danivilla9 Can you please try also run the tests on the windows? you can use this workflow: https://github.com/containers/podman-desktop-e2e/actions/workflows/desktop-e2e-test-job-windows.yaml.

@odockal odockal self-requested a review September 25, 2024 09:28
Copy link
Collaborator

@odockal odockal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We found out after discussion that we also need to add a test for a crc-extension dependency - Red Hat Authentication. So to check the presence of RH SSO once the OpenShift Local is installed and its state should be part of e2e tests.

We also encountered a bug. Which will be reported. We might consider to eventually add a test to cover this bug in another issue. @danivilla9 ^^

Signed-off-by: Daniel Villanueva <davillan@redhat.com>
@odockal
Copy link
Collaborator

odockal commented Sep 26, 2024

@danivilla9 please resolve the conflicts so we can merge the PR.

@danivilla9 danivilla9 merged commit e723f56 into crc-org:main Sep 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants