-
Notifications
You must be signed in to change notification settings - Fork 26
chore(test): adding playwright e2e test #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0bb8e15
to
167ab9f
Compare
Signed-off-by: Daniel Villanueva <davillan@redhat.com>
Signed-off-by: Daniel Villanueva <davillan@redhat.com>
167ab9f
to
a80bdfe
Compare
Signed-off-by: Daniel Villanueva <davillan@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me, but I leave the approval to @odockal.
Description for the PR should be updated:
- (2,3,4) should be updates to call pnpm from root of the podman-desktop
- use yarn for the extension, because it is not migrated to pnpm yet.
Can't test it on Windows and seems |
@danivilla9 Can you please try also run the tests on the windows? you can use this workflow: https://github.com/containers/podman-desktop-e2e/actions/workflows/desktop-e2e-test-job-windows.yaml. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We found out after discussion that we also need to add a test for a crc-extension dependency - Red Hat Authentication. So to check the presence of RH SSO once the OpenShift Local is installed and its state should be part of e2e tests.
We also encountered a bug. Which will be reported. We might consider to eventually add a test to cover this bug in another issue. @danivilla9 ^^
Signed-off-by: Daniel Villanueva <davillan@redhat.com>
@danivilla9 please resolve the conflicts so we can merge the PR. |
Fixes issue #313. This PR introduces E2E tests using Playwright
In order to test:
1-Clone the podman-desktop repository
2-Go to podman-desktop folder
3-Execute
pnpm install
4-Execute
pnpm test:e2e:build
6-Set environment variable executing:
export PODMAN_DESKTOP_ARGS="/path/to/podman-desktop"
7-Go to crc-extension folder
8-Execute
yarn install
8-Execute
yarn test:e2e
*Remember that you have to use the latest version of @podman-desktop/tests-playwright in order to execute the tests