Apache Superset: Improve probing including pre-release versions

[amotl]

About

Apache Superset 4.1.3rc1 released on May 6 could make our CI happy again.

References

• Make Superset compatible with marshmallow>=4.0.0 apache/superset#33162 (comment)

[coderabbitai]

Warning

Rate limit exceeded

@amotl has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 22 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between fb23b3a and 1ea514f.

📒 Files selected for processing (1)

• .github/workflows/application-apache-superset.yml (2 hunks)

✨ Finishing Touches

🧪 Generate Unit Tests

• Create PR with Unit Tests
• Post Copyable Unit Tests in Comment
• Commit Unit Tests in branch superset-4.1.3rc1

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[amotl]

Hi @mistercrunch and @sadpandajoe,

thanks a stack for your positive reply at apache/superset#33162 (comment), and for releasing Apache Superset 4.1.3rc1, which resolves this problem for us and possibly others.

Do you also intend to backport apache/superset#33216 to any 3.x branch, and subsequently run a release, or is it out of service?

It also looks like the same patch needs to be forward-ported to Apache Superset 5.x, as currently only Apache Superset 4.x is succeeding.

With kind regards,
Andreas.

[mistercrunch]

Probably not. LTS comes at the cost of moving forward faster. Looking for more people to help with release management, but highly encourage people to push their environment forward along with us.

[amotl]

Thanks for your reply. So we will submit a patch like apache/superset#33216 to the development head to cover an upcoming 5.x release, and remove Apache Superset 3.x from our testing rig, because it will never get fixed?

[mistercrunch]

Trying to think of the best way to either a) offer some LTS where it matters, or b) marking older versions as "not supported, may have security issues". Realistically given the focus of current maintainers, support previous/current/next major is already challenging.

The main issue is around supporting a large tree of dependency both on the backend and frontend. Some tooling offers issue reporting on the dep tree, flagging individual librairies down the tree that have issues, but the whole thing is challenging to manage. Realistically the only way to stay on top of it is automation/tooling, using things like Snyk and @dependabot / @supersetbot to help in the process. Now given the largely manual process dictated by the ASF the includes humans voting release through email, things get pretty hard.

Release automation / tooling would really help. It's probably a matter of reinvesting in custom tooling like https://github.com/apache-superset/cherrytree and https://github.com/apache-superset/supersetbot - or go with the latest AI-powered tooling to try and support/automate release management. Until AI takes over, this would require a significant amount of good old human-powered engineering.

[mistercrunch]

Another thought on the current release process. It seems possible for maintainers to allow people like you who want older releases to be pushed forward, to open PRs against release branches, and allow release branches to be ahead of official release (that require email voting, issue of multiple release candidates, and finally release publishing).

So maybe we allow for release branches to evolve, so say you target the 3.1 branch with the marshmallow boundary PR, we merge it, and they 3.1 is ahead of the latest official release, say 3.1.3, and maybe eventually - ideally through some automation, 3.1.4rc1 gets submitted for release. Or maybe 3.1 just keeps pilling up LTS-type fixes and remains supported longer term.

[amotl]

Now given the largely manual process dictated by the ASF the includes humans voting release through email, things get pretty hard.

Oh wow. I would never have imagined such obstacles. Thanks for your extensive elaboration.

Another thought on the current release process. It seems possible for maintainers to allow people like you who want older releases to be pushed forward, to open PRs against release branches, and allow release branches to be ahead of official release (that require email voting, issue of multiple release candidates, and finally release publishing).

So maybe we allow for release branches to evolve, so say you target the 3.1 branch with the marshmallow boundary PR, we merge it, and they 3.1 is ahead of the latest official release, say 3.1.3, and maybe eventually - ideally through some automation, 3.1.4rc1 gets submitted for release. Or maybe 3.1 just keeps pilling up LTS-type fixes and remains supported longer term.

Yes indeed. On the CrateDB repository, we are maintaining the 4.x and 5.x branches, dropped support for 3.x, and are currently transitioning to 6.x. All active branches of major versions accept changes, and we are employing Mergify to support fluent backports of PRs without needing to do that manually.

Of course, it is naturally up to you which major versions you will be supporting. Our thinking just was that because 5.x is still in its infancy, we felt it would be obvious to keep 3.x and 4.x active, but we haven't been able to find a 3.x branch to direct our dependency fix to.

Release automation / tooling [around dependency management] would really help.

I don't disagree, but we are really looking at "just accepting patches" on particular spots where things go south, in this case with Marshmallow 4.x. This does not necessarily mean to redesign the whole dependency management machinery. I absolutely hear you on maintainer burnout topics, related to all of that. I think no matter what, KISS approaches are the only ones that are bearable. 🍀

[mistercrunch]

If we wanted to work around the hurdles of "official ASF releases" which require an email vote, tarballs on a ASF-hosted SVN and all, people can/could point their build system to our release branches. In our case, the minor (ie 4.1) is a branch, and the official release (ie 4.1.1) is a tag on that branch. In theory we could move faster if you build on 4.1 and we can easily target PRs to those branches (say fixing the marshmallow<=4.x ceiling thing). Then you're still on 4.1 but ahead of the latest ASF release. It becomes a bit of a moving target but might achieve your goals.