Skip to content

Fix simple IO bugs #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2025
Merged

Fix simple IO bugs #130

merged 1 commit into from
Apr 26, 2025

Conversation

craigthomas
Copy link
Owner

This PR fixes three simple IO bugs. First, the SYNC instruction was hanging the emulator due to the fact that the CPU was put into a suspended state, without any ability to trigger any additional interrupts. Second, video modes should not be updated when the SAM control registers are updated - only when the data register for the VDG is written to should the video mode be updated. Finally, it was possible to write into the ROM address space through the IO mapped memory segment of $FF00 - $FFFF. This PR fixes these specific IO bugs.

Copy link

codecov bot commented Apr 26, 2025

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Project coverage is 57.39%. Comparing base (e22e9cd) to head (1f434cc).

Files with missing lines Patch % Lines
...a/ca/craigthomas/yacoco3e/components/Emulator.java 0.00% 4 Missing ⚠️
.../craigthomas/yacoco3e/components/IOController.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #130      +/-   ##
============================================
- Coverage     57.40%   57.39%   -0.02%     
+ Complexity     1028     1027       -1     
============================================
  Files            68       68              
  Lines          4562     4556       -6     
  Branches        514      514              
============================================
- Hits           2619     2615       -4     
+ Misses         1859     1857       -2     
  Partials         84       84              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@craigthomas craigthomas merged commit 594dc8a into main Apr 26, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant