Skip to content

PIA Refactoring #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2025
Merged

PIA Refactoring #128

merged 2 commits into from
Apr 21, 2025

Conversation

craigthomas
Copy link
Owner

This PR refactors the code around the Peripheral Interface Adapters. Previously, a set of unsigned byte objects were used to represent the state of the various PIA registers within the IO controller interface. The change here pulls out those bytes and instead creates a dedicated series of PIA objects to interface with different hardware devices. Unit tests updated to catch new conditions.

Copy link

codecov bot commented Apr 21, 2025

Codecov Report

Attention: Patch coverage is 50.31056% with 80 lines in your changes missing coverage. Please review.

Project coverage is 57.61%. Comparing base (cd43b31) to head (7fa91fd).

Files with missing lines Patch % Lines
.../craigthomas/yacoco3e/components/IOController.java 33.89% 39 Missing ⚠️
...java/ca/craigthomas/yacoco3e/components/PIA1a.java 44.44% 7 Missing and 3 partials ⚠️
...java/ca/craigthomas/yacoco3e/components/PIA1b.java 60.00% 5 Missing and 3 partials ⚠️
...java/ca/craigthomas/yacoco3e/components/PIA2b.java 42.85% 6 Missing and 2 partials ⚠️
...n/java/ca/craigthomas/yacoco3e/components/PIA.java 58.82% 6 Missing and 1 partial ⚠️
...java/ca/craigthomas/yacoco3e/components/PIA2a.java 50.00% 4 Missing and 2 partials ⚠️
...a/ca/craigthomas/yacoco3e/components/Keyboard.java 90.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #128      +/-   ##
============================================
- Coverage     57.63%   57.61%   -0.03%     
- Complexity     1018     1028      +10     
============================================
  Files            62       67       +5     
  Lines          4506     4546      +40     
  Branches        527      514      -13     
============================================
+ Hits           2597     2619      +22     
- Misses         1828     1843      +15     
- Partials         81       84       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@craigthomas craigthomas merged commit c3510ea into main Apr 21, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant