Skip to content

Conversation

@brynrhodes
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 19.86%. Comparing base (9b02acb) to head (14ee75c).

Files with missing lines Patch % Lines
...ava/org/opencds/cqf/tooling/packaging/Package.java 50.00% 1 Missing and 3 partials ⚠️
...encds/cqf/tooling/packaging/r4/PackageMeasure.java 66.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #588      +/-   ##
============================================
- Coverage     19.87%   19.86%   -0.01%     
- Complexity     1651     1652       +1     
============================================
  Files           310      310              
  Lines         27302    27307       +5     
  Branches       4327     4331       +4     
============================================
- Hits           5425     5424       -1     
- Misses        20972    20975       +3     
- Partials        905      908       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@raleigh-g-thompson raleigh-g-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the code in the resolvePrimaryLibraryDependencies function works as expected, but not clear from the code the exact intent of this logic with regards to the local primaryLibrary and the instance's primaryLibrary value.

Copy link
Contributor

@raleigh-g-thompson raleigh-g-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed implementation with Bryn and will accept current changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants