Implement Component Criteria Stratifiers #798
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anch. Currently, everything compiles but several tests fail because changes from R4MeasureDefBuilder have not yet been merged, which will be difficult to merge.
…till several test failures.
…e in MeasureEvaluator.
…extracting out a LibraryHandler to init the libs.
…tion and cut down on structure mutation as much as possible.
… resolve Sonar issues.
…ous-variable-scoring-post-creteria-strat-merge
…bservation evaluation.
…ous-variable-scoring-post-creteria-strat-merge
…es. All tests pass, but further optimizations are needed both to code quality and possible bugs not captured by tests.
…iondef-collection-optimize-2
…g. Rough implementation and code cleanup needed but all tests pass.
…onDef and match them with stratum and stratum populations in the build in order to score continuous variable observations.
…r up the call chain.
…ot to mutate the enclosing structures while building what will be added to them.
…t duplicate quantities are handled. Address TODOs and delete cruft.
…ionResultHandler. Make use of LibraryInitHandler for pre-evaluation.
…fier builder. Address sonar feedback.
…iondef-collection-optimize-2
…kle TODOs for parts of the code that need to change.
|
Formatting check succeeded! |
…Add more verification methods to Measure. Add TODOs for design and functional changes.
…nt-criteria-stratifiers-2
lukedegruchy
changed the title
…till not correct.
… measure evaluation stratifier def processing.
…tratifierBuilder to MeasureEvaluator. This change hasn't yet been activated. Also, move "post evaluation" multi-subject MeasureDef code to a new dedicated class. More TODOs.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.