Skip to content

Conversation

@lukedegruchy
Copy link
Contributor

@lukedegruchy lukedegruchy commented Oct 6, 2025

  • Introduce NpmPackageLoader as an interface with default method to enforce the NPM loading contract
  • This version of NPM functionality loads FHIR resources directly, and can theoretically support loading any FHIR resources, though in practice we want to limit this to Measures, Libraries, PlanDefinitions, etc
  • Make this FHIR version agnostic, as it supports both R4 and R5.
  • Add an NpmNamespaceManager which captures the function to extract namespaces from NPM packages
  • Add R4 and R5 tests verify the contract for loading NPM packages works with packages built for both R4 and R5

@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Formatting check succeeded!

@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

❌ Patch coverage is 42.95302% with 85 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.22%. Comparing base (7926c47) to head (783a480).
⚠️ Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
...opencds/cqf/fhir/utility/npm/NpmPackageLoader.java 24.63% 44 Missing and 8 partials ⚠️
...fhir/utility/npm/BaseNpmPackageLoaderInMemory.java 53.57% 24 Missing and 2 partials ⚠️
...hir/utility/npm/r4/R4NpmPackageLoaderInMemory.java 72.72% 3 Missing ⚠️
...hir/utility/npm/r5/R5NpmPackageLoaderInMemory.java 72.72% 3 Missing ⚠️
...ncds/cqf/fhir/utility/npm/NpmNamespaceManager.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #765      +/-   ##
============================================
+ Coverage     72.95%   73.22%   +0.27%     
- Complexity      235      268      +33     
============================================
  Files           538      556      +18     
  Lines         25065    25792     +727     
  Branches       3170     3231      +61     
============================================
+ Hits          18285    18886     +601     
- Misses         5261     5343      +82     
- Partials       1519     1563      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lukedegruchy lukedegruchy changed the title First commit. First round of NPM package loading functionality for Measures and Libraries Oct 7, 2025
@lukedegruchy lukedegruchy marked this pull request as ready for review October 7, 2025 20:59
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants