Skip to content

Conversation

@lukedegruchy
Copy link
Contributor

@lukedegruchy lukedegruchy commented Sep 2, 2025

  • Introduce the concept of an EngineInitializationContext
  • Use it to capture state with which to initialize CqlEngines within clinical-reasoning.
  • This will initially capture Repository, NpmPackageLoader, and EvaluationSettings
  • As we deprecate and then remove functionality that stores qualifying CI resources within Repository, that construct will be dropped from the context.
  • Add an NPM LibrarySourceProvider and a unit test
  • Add an NPM ModelInfoProvider
  • Register both in the CqlEngine's LibraryManager

…o capture state with which to initialize CqlEngines within clinical-reasoning. This will initially capture Repository, NpmPackageLoader, and EvaluationSettings, but as we deprecate and then remove functionality that stores qualifying CI resources within Repository, that construct will be dropped from the context.
…n, including an NPM library provider and a model info provider.
@github-actions
Copy link

github-actions bot commented Sep 2, 2025

Formatting check succeeded!

@lukedegruchy lukedegruchy changed the title Introduce EngineInitializationContext to capture Repository and NpmPackageLoader context to initialize the CQL Engine Add code to initialize CQL engine with NPM library and modelinfo providers and start setting up downstream code to use this Sep 2, 2025
@codecov
Copy link

codecov bot commented Sep 2, 2025

Codecov Report

❌ Patch coverage is 60.84243% with 251 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.85%. Comparing base (13ac344) to head (db46ee6).

Files with missing lines Patch % Lines
...qf/fhir/utility/npm/NpmPackageLoaderWithCache.java 0.00% 42 Missing ⚠️
...cqf/fhir/utility/npm/NpmPackageLoaderInMemory.java 71.83% 28 Missing and 12 partials ⚠️
...pencds/cqf/fhir/utility/npm/NpmResourceHolder.java 53.01% 31 Missing and 8 partials ⚠️
...opencds/cqf/fhir/cr/hapi/config/r4/CrR4Config.java 0.00% 27 Missing ⚠️
...f/fhir/utility/npm/MeasureOrNpmResourceHolder.java 43.90% 17 Missing and 6 partials ⚠️
...cds/cqf/fhir/cr/hapi/config/CrProcessorConfig.java 0.00% 20 Missing ⚠️
...s/cqf/fhir/utility/repository/ig/IgRepository.java 35.48% 18 Missing and 2 partials ⚠️
...ir/utility/npm/MeasureOrNpmResourceHolderList.java 78.37% 6 Missing and 2 partials ⚠️
...opencds/cqf/fhir/cql/npm/NpmModelInfoProvider.java 64.70% 6 Missing ⚠️
...s/cqf/fhir/cr/hapi/config/dstu3/CrDstu3Config.java 0.00% 5 Missing ⚠️
... and 9 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #727      +/-   ##
============================================
- Coverage     73.21%   72.85%   -0.36%     
  Complexity      211      211              
============================================
  Files           489      500      +11     
  Lines         23010    23535     +525     
  Branches       2970     3011      +41     
============================================
+ Hits          16846    17147     +301     
- Misses         4706     4900     +194     
- Partials       1458     1488      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 3, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants