NPM Packages: Support loading Measures, Libraries, CQL included Libraries and cross-package Libraries across NPM Packages #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… specified NpmPackages.
|
Formatting check succeeded! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #628 +/- ##
============================================
+ Coverage 72.14% 72.20% +0.05%
Complexity 123 123
============================================
Files 469 476 +7
Lines 21958 22253 +295
Branches 2849 2873 +24
============================================
+ Hits 15842 16067 +225
- Misses 4705 4764 +59
- Partials 1411 1422 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…e and associated Libraries. Add a canonical URL parameter to $evaluate-measure and use that. Start writing a test.
…ieval. Checkstyle. Rollback some old changes. Spotless. Change conditional logic to match Library with Versioned and Model identifiers. Ensure we pass down NpmResourceHolderGetter everywhere it's required.
…is passed from the downstream app. Set up new evaluate measure with URL API in clinical-reasoning.
…to its own static class: EnginesNpmLibraryHandler. Get rid of singleton and add default implementation to NpmResourceHolderGetter interface.
…m getter instead of the built Holder object and then converting the VersionedIdentifier and ModelIdentifier.
… Library from URL functionality.
… providers the main providers.
…e holder class and interface. Make clear each is just for R4.
…ource holder class.
…ure. Add direct tests in clinical-reasoning.
… loader and an InMemoryRepository. Move code to utilities so the CQL and cr packages can make use of it.
…ces configured to use NPM at the REST layer. Add TODO.
…NPM queries for Libraries and Measures and extract them to a new class: R4FhirOrNpmResourceProvider with a factory: R4FhirOrNpmResourceProviderFactory. Ensure all client code uses this new code correctly and eliminates any now redundant dependencies.
…Add convenience method to R4FhirOrNpmResourceProvider. Slightly improve error handling.
…ression exceptions.
…ke use of CQL. Cleanup some dead code and TODOS. Add new TODOs.
…hough stubbing it with the no-op version in some places. Test this fully with the R4CqlExecutionService, including with a new NPM package. Start enforcing explicitly passing in the NpmPackageLoader in Engines. Start implementing namespace resolution for direct evaluation of libraries without an NPM package cache.
…lso, change the NpmPackageLoader to return an NpmNamespaceManager.
…ntifiers in CqlExecutionProcessor.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.