Skip to content

ci: enable ubsan for clang and gcc #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2025
Merged

ci: enable ubsan for clang and gcc #935

merged 1 commit into from
Jul 25, 2025

Conversation

mizvekov
Copy link
Collaborator

@mizvekov mizvekov commented Jul 18, 2025 •
edited
Loading

And fixes a member function call through a null pointer and an incorrect use of static_cast.

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://935.mrdocs.prtest2.cppalliance.org/index.html

@mizvekov mizvekov force-pushed the ci-enable-sanitizers branch from eddf81b to 96dfd25 Compare July 18, 2025 16:59
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://935.mrdocs.prtest2.cppalliance.org/index.html

@mizvekov mizvekov force-pushed the ci-enable-sanitizers branch from 96dfd25 to bda54b6 Compare July 18, 2025 17:48
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://935.mrdocs.prtest2.cppalliance.org/index.html

@mizvekov mizvekov force-pushed the ci-enable-sanitizers branch from bda54b6 to 2c72399 Compare July 18, 2025 17:58
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://935.mrdocs.prtest2.cppalliance.org/index.html

@mizvekov mizvekov force-pushed the ci-enable-sanitizers branch 2 times, most recently from 0e95a20 to 8c2dc6d Compare July 18, 2025 18:19
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://935.mrdocs.prtest2.cppalliance.org/index.html

1 similar comment
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://935.mrdocs.prtest2.cppalliance.org/index.html

@mizvekov mizvekov force-pushed the ci-enable-sanitizers branch from 8c2dc6d to 4e1ce5a Compare July 18, 2025 18:32
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://935.mrdocs.prtest2.cppalliance.org/index.html

@mizvekov mizvekov force-pushed the ci-enable-sanitizers branch from 4e1ce5a to 920237b Compare July 18, 2025 18:45
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://935.mrdocs.prtest2.cppalliance.org/index.html

@mizvekov mizvekov force-pushed the ci-enable-sanitizers branch 2 times, most recently from 82be0c6 to f646b9b Compare July 18, 2025 18:59
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://935.mrdocs.prtest2.cppalliance.org/index.html

1 similar comment
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://935.mrdocs.prtest2.cppalliance.org/index.html

@mizvekov mizvekov force-pushed the ci-enable-sanitizers branch from f646b9b to b6abb26 Compare July 18, 2025 19:06
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://935.mrdocs.prtest2.cppalliance.org/index.html

@mizvekov mizvekov force-pushed the ci-enable-sanitizers branch from b6abb26 to 4f475c1 Compare July 18, 2025 21:39
@mizvekov mizvekov changed the title ci: enable sanitizers ci: enable UBSan for clang and gcc Jul 18, 2025
@mizvekov mizvekov changed the title ci: enable UBSan for clang and gcc ci: enable ubsan for clang and gcc Jul 18, 2025
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://935.mrdocs.prtest2.cppalliance.org/index.html

@mizvekov mizvekov force-pushed the ci-enable-sanitizers branch from 4f475c1 to 509ba35 Compare July 21, 2025 20:13
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://935.mrdocs.prtest2.cppalliance.org/index.html

@mizvekov mizvekov force-pushed the ci-enable-sanitizers branch 2 times, most recently from 08c6ad1 to 202774d Compare July 22, 2025 19:26
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://935.mrdocs.prtest2.cppalliance.org/index.html

@mizvekov mizvekov force-pushed the ci-enable-sanitizers branch from 202774d to a59c7aa Compare July 22, 2025 19:34
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://935.mrdocs.prtest2.cppalliance.org/index.html

@mizvekov mizvekov force-pushed the ci-enable-sanitizers branch from a59c7aa to 9c814e2 Compare July 24, 2025 00:41
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://935.mrdocs.prtest2.cppalliance.org/index.html

@alandefreitas alandefreitas force-pushed the ci-enable-sanitizers branch from 9c814e2 to 0c45e5c Compare July 24, 2025 03:12
alandefreitas
alandefreitas reviewed Jul 24, 2025
View reviewed changes
.github/workflows/ci.yml Outdated
@@ -215,7 +217,7 @@ jobs:

- name: Download LLVM Binaries
id: llvm-download
if: steps.llvm-cache.outputs.cache-hit != 'true'
if: steps.llvm-cache.outputs.cache-hit != 'true' && !(matrix.ubsan || matrix.asan || matrix.msan)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we should also upload these binaries. The binaries on the website are not only useful for developers. They're also helpful when testing CI, and the GHA cache is not yet available.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be really, really good to upload these binaries to the site as well.

I even thought this would already happen because of that automatic matrix, but I guess the naming conflict (with and without sanitizer having the same filename) is probably blocking it. But that’s a problem, because in a run where the cache is cold, there’s a chance the job with sanitizer finishes first and uploads the sanitizer version to the server as the default one.

You could fix this by filtering out those sanitizer jobs in the script that filters the binaries, but honestly, at that point it’s less work to just upload the files there.

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://935.mrdocs.prtest2.cppalliance.org/index.html

@mizvekov mizvekov force-pushed the ci-enable-sanitizers branch from 0c45e5c to edc6eca Compare July 24, 2025 17:35
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://935.mrdocs.prtest2.cppalliance.org/index.html

@mizvekov mizvekov force-pushed the ci-enable-sanitizers branch from edc6eca to c9ec61c Compare July 24, 2025 18:16
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://935.mrdocs.prtest2.cppalliance.org/index.html

@mizvekov mizvekov force-pushed the ci-enable-sanitizers branch 3 times, most recently from 9bec565 to d6a3c90 Compare July 24, 2025 18:35
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://935.mrdocs.prtest2.cppalliance.org/index.html

@mizvekov mizvekov force-pushed the ci-enable-sanitizers branch from d6a3c90 to 88a3341 Compare July 24, 2025 18:37
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://935.mrdocs.prtest2.cppalliance.org/index.html

@mizvekov mizvekov force-pushed the ci-enable-sanitizers branch 2 times, most recently from 0884335 to 82da5de Compare July 24, 2025 22:43
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://935.mrdocs.prtest2.cppalliance.org/index.html

@mizvekov mizvekov force-pushed the ci-enable-sanitizers branch 2 times, most recently from 5c20563 to f9aa3ab Compare July 24, 2025 22:48
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://935.mrdocs.prtest2.cppalliance.org/index.html

@mizvekov mizvekov force-pushed the ci-enable-sanitizers branch from f9aa3ab to c247704 Compare July 24, 2025 23:09
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://935.mrdocs.prtest2.cppalliance.org/index.html

@alandefreitas alandefreitas merged commit 3fd05bb into cppalliance:develop Jul 25, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alandefreitas alandefreitas alandefreitas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mizvekov @cppalliance-bot @alandefreitas