Skip to content

[container.insert.return] Fix description of insert-return-type #8030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2025

Conversation

adr26
Copy link
Contributor

@adr26 adr26 commented Jun 27, 2025

Use "for exposition only" for consistency with usage elsewhere in the spec, and for the clarity/grammatical correctness of this sentence.

@tkoeppe
Copy link
Contributor

tkoeppe commented Jun 27, 2025

I wouldn't really call this a "typo"; nothing is mispelled here. It's more of a stylistic choice.

Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing phrasing needs a hyphen in my book, and I like consistency.
So, I'm for adding "for".

@jwakely
Copy link
Member

jwakely commented Jun 27, 2025

Yeah, seems like an improvement, although the commit message could omit mentioning "typo" :)

@adr26 adr26 changed the title [container.insert.return] Fix typo in description of insert-return-type [container.insert.return] Fix description of insert-return-type Jun 27, 2025
@adr26
Copy link
Contributor Author

adr26 commented Jun 27, 2025

I should have said a "typographical omission" but wrote "typo" for short, which has overloaded semantics with "spelling or punctuation error" :)

@jwakely - I have updated the PR title, but can't retroactively change the commit message without recreating the branch. Should I do that?

@jensmaurer
Copy link
Member

jensmaurer commented Jun 27, 2025

Changing the title of the pull request does not change the title of the commit message.
You need to "git commit --amend", change it there, and then force-push.
(Yes, force-pushing is fine.)

@tkoeppe
Copy link
Contributor

tkoeppe commented Jun 27, 2025

(We can also change that when squash-merging, but it might be good PR handling practice. Yes, you can modify the PR branch as much as you like, and push and force-push as you see fit.)

Use "for exposition only" for consistency with usage elsewhere in the spec, and for the clarity/grammatical correctness of this sentence.
@adr26 adr26 force-pushed the insert-return-type branch from a0cfa4e to 04bf1a3 Compare June 29, 2025 08:05
@adr26
Copy link
Contributor Author

adr26 commented Jun 29, 2025

Thanks for the clarification @jensmaurer - I force-pushed to my fork with the commit message updated.

Is everything OK now (once the checks come back clean)?

Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@tkoeppe
Copy link
Contributor

tkoeppe commented Jun 29, 2025

Thanks!

@tkoeppe tkoeppe merged commit 0096f88 into cplusplus:main Jun 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants