-
Notifications
You must be signed in to change notification settings - Fork 777
[container.insert.return] Fix description of insert-return-type #8030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I wouldn't really call this a "typo"; nothing is mispelled here. It's more of a stylistic choice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing phrasing needs a hyphen in my book, and I like consistency.
So, I'm for adding "for".
Yeah, seems like an improvement, although the commit message could omit mentioning "typo" :) |
I should have said a "typographical omission" but wrote "typo" for short, which has overloaded semantics with "spelling or punctuation error" :) @jwakely - I have updated the PR title, but can't retroactively change the commit message without recreating the branch. Should I do that? |
Changing the title of the pull request does not change the title of the commit message. |
(We can also change that when squash-merging, but it might be good PR handling practice. Yes, you can modify the PR branch as much as you like, and push and force-push as you see fit.) |
Use "for exposition only" for consistency with usage elsewhere in the spec, and for the clarity/grammatical correctness of this sentence.
a0cfa4e
to
04bf1a3
Compare
Thanks for the clarification @jensmaurer - I force-pushed to my fork with the commit message updated. Is everything OK now (once the checks come back clean)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks
Thanks! |
Use "for exposition only" for consistency with usage elsewhere in the spec, and for the clarity/grammatical correctness of this sentence.