-
Notifications
You must be signed in to change notification settings - Fork 778
Follow-up to P2546, "Debugging Support" #7642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tkoeppe
merged 7 commits into
cplusplus:main
from
hubert-reinterpretcast:P2546-follow-up
Mar 15, 2025
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6e3a4b5
Re-word `breakpoint` to fix untrue statement-of-fact
fe98e6e
Case where resumption does not resume as if the function is invoked
d817067
breakpoint when no debugger is present
4d24c66
is_debugger_present: Fix unsupported statement-of-fact
a5c7585
is_debugger_present: ptrace is not POSIX; LSB uses "tracing process"
67706d2
is_debugger_present: Clarify intent to avoid false positives
cb8fc31
Replace newly added "abend"
hubert-reinterpretcast File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This replaces "POSIX" with "Linux Standard Base". Is there a particular reason for that? Does POSIX not cover the needed functionality?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although
ptrace
is present in most UNIX-like systems, it isn't part of POSIX. The LSB is a much narrower scope than POSIX, but it is a standard, unlike families like "BSD" or "SysV". So if we want a standard that includesptrace
, LSB makes sense.However, the wording never mentions
prrace
it just talks about "tracing" and "a tracer parent process" which is still meaningful even in e.g. HP-UX which replacedptrace
withttrace
, and in Solaris throughptrace
but also via procfs. So maybe it's OK.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using "POSIX" in conjunction with the handwaving implies that the handwaving is necessarily meaningful for all possible implementations of POSIX. That it is probably meaningful for extant implementations of POSIX does not make me feel any better about using "POSIX" without qualification.