Skip to content

[array.cons] Fix various wording issues #7054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

Eisenwave
Copy link
Member

@Eisenwave Eisenwave commented Jun 8, 2024

This PR fixes the following issues:

  • "The conditions for an aggregate shall be met." does not specify that array meets those requirements, and usually we say this explicitly instead of letting the reader figure it out based on the subclause the wording is in. If we reworded this sentence to say "An array is an aggregate" (or something similar), this would just be repeating [array.overview] p2, and we don't need the same normative wording copied and pasted multiple times. Therefore, the first sentence is deleted.

  • "Class array" is wrong. array is a class template, not a class. In the rest of [array], we say "an array" which is not wrong at least; it can be seen as a shorthand for "a specialization of the array class template".

  • "implicit move constructor" is wrong. It's not a defined term, and could reasonably be interpreted to mean "the non-explicit move constructor", i.e. converting constructor. That's not what we are trying to say here; we are talking about the implicitly-declared move constructor.

I believe the LWG intent is clear enough for all of these issues to be editorial.

Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like an improvement, and doesn't conflict with https://cplusplus.github.io/LWG/issue4069

@tkoeppe tkoeppe requested a review from jensmaurer July 29, 2024 13:53
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@tkoeppe tkoeppe merged commit 609068d into cplusplus:main Jul 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants