-
Notifications
You must be signed in to change notification settings - Fork 778
Consistent comma after e.g. and i.e. #1512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2257,7 +2257,7 @@ | |
\end{example} | ||
|
||
\begin{example} | ||
One can make a class uncopyable, i.e. move-only, by using deleted | ||
One can make a class uncopyable, i.e., move-only, by using deleted | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems like abuse of "i.e." -- uncopyable and move-only are not equivalent. More drastic rewording seems necessary here. |
||
definitions of the copy constructor and copy assignment operator, and then | ||
providing defaulted definitions of the move constructor and move assignment operator. | ||
\begin{codeblock} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -99,13 +99,13 @@ | |
|
||
\begin{itemize} | ||
\item | ||
if $C_a > C_t$, the waiting function should wake as soon as possible, i.e. $C_a + D_i + D_m$, | ||
if $C_a > C_t$, the waiting function should wake as soon as possible, i.e., $C_a + D_i + D_m$, | ||
since the timeout is already satisfied. \begin{note} This specification may result in the total | ||
duration of the wait decreasing when measured against a steady clock. \end{note} | ||
|
||
\item | ||
if $C_a <= C_t$, the waiting function should not time out until \tcode{Clock::now()} returns a | ||
time $C_n >= C_t$, i.e. waking at $C_t + D_i + D_m$. \begin{note} When the clock is adjusted | ||
time $C_n >= C_t$, i.e., waking at $C_t + D_i + D_m$. \begin{note} When the clock is adjusted | ||
backwards, this specification may result in the total duration of the wait increasing when | ||
measured against a steady clock. When the clock is adjusted forwards, this specification may | ||
result in the total duration of the wait decreasing when measured against a steady clock. | ||
|
@@ -147,7 +147,7 @@ | |
An \defn{execution agent} is an entity such as a thread that may perform work in parallel with | ||
other execution agents. \begin{note} Implementations or users may introduce other kinds of | ||
agents such as processes or thread-pool tasks. \end{note} The calling agent is determined by | ||
context, e.g. the calling thread that contains the call, and so on. | ||
context, e.g., the calling thread that contains the call, and so on. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I do not think we need both an 'e.g.' and an 'and so on' here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I actually think the entire "e.g." part needs a more drastic rewrite. This just doesn't read well. Oh, and does this note attempt to define the term "calling agent"? Then it would be totally misguided. |
||
|
||
\pnum | ||
\begin{note} Some lockable objects are ``agent oblivious'' in that they work for any | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More damage to the English language perpretrated by Strunk and White, but OK, this is the dominant American English style, so let's put up with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I believe the "comma after i.e." thing is totally misguided. Nobody knows what "i.e." and "e.g." means in the expanded form, plus it's Latin anyway, so the argument "oh, it's a complete sentence lookalike, so should have commas around it" is broken. (Have you ever seen the expanded form in English?). We don't put a comma after "but" or "where" either.