[junit] Mark test as failed when finding a fatal error when xctest is used directly #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelofabri
commented
May 20, 2025
| /// $1 = whole error. | ||
| /// it varies a lot, not sure if it makes sense to catch everything separately | ||
| static let regex = XCRegex(pattern: #"^(fatal error:.*)$"#) | ||
| static let regex = XCRegex(pattern: #"^((?:.* )?[fF]atal error:.*)$"#) |
Author
There was a problem hiding this comment.
let me know if you'd rather have a separate capture group for this
Owner
There was a problem hiding this comment.
Looking at the example test file... Do you expect the prefix to always be the file / line number? If so, I think we should make a separate group, so we can extract that information.
cpisciotta
reviewed
Oct 30, 2025
Owner
cpisciotta
left a comment
cpisciotta
left a comment
There was a problem hiding this comment.
Thanks for the contribution @marcelofabri! Do you mind resolving the conflicts and addressing the one comment? After which, happy to get this in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the bazel world, it's common to run tests with the
xctestbinary directly instead of callingxcodebuild(reference) for performance reasons.However,
xctestdoesn't handle crashes very well: it abruptly stops the execution, without marking the test case as failed. Because of that,xcbeautifydoesn't mark the test as failed in the JUnit XML (in fact it's not even added).This PR handles that.