chore(ui): toggle sidebar icon on sidebar open #2072
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cotes2020
reviewed
Nov 30, 2024
There was a problem hiding this comment.
Hi, @kungfux,
Please don't modify the original design, the switch icon doesn't need to change dynamically.
It is true that some designs favor the use of an 'x', but then the 'x' design logically belongs to the sidebar, not in the original switch position.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Change the sidebar icon to 'close' when the sidebar is open to make the purpose of the button clear.
This is a nice to have improvement, as suggested in #2059.