imp!: remove unused ICS02 entrypoints (backport #495) (#496)

Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com>

Author: mergify[bot]

abi/ICS26Router.json

@@ -921,48 +921,6 @@
     "outputs": [],
     "stateMutability": "nonpayable"
   },
-  {
-    "type": "function",
-    "name": "updateClient",
-    "inputs": [
-      {
-        "name": "clientId",
-        "type": "string",
-        "internalType": "string"
-      },
-      {
-        "name": "updateMsg",
-        "type": "bytes",
-        "internalType": "bytes"
-      }
-    ],
-    "outputs": [
-      {
-        "name": "",
-        "type": "uint8",
-        "internalType": "enum ILightClientMsgs.UpdateResult"
-      }
-    ],
-    "stateMutability": "nonpayable"
-  },
-  {
-    "type": "function",
-    "name": "upgradeClient",
-    "inputs": [
-      {
-        "name": "clientId",
-        "type": "string",
-        "internalType": "string"
-      },
-      {
-        "name": "upgradeMsg",
-        "type": "bytes",
-        "internalType": "bytes"
-      }
-    ],
-    "outputs": [],
-    "stateMutability": "nonpayable"
-  },
   {
     "type": "function",
     "name": "upgradeToAndCall",

contracts/interfaces/IICS02Client.sol

@@ -2,7 +2,6 @@
 pragma solidity ^0.8.28;
 
 import { IICS02ClientMsgs } from "../msgs/IICS02ClientMsgs.sol";
-import { ILightClientMsgs } from "../msgs/ILightClientMsgs.sol";
 import { ILightClient } from "./ILightClient.sol";
 
 /// @title ICS02 Light Client Router Interface
@@ -62,27 +61,11 @@ interface IICS02Client {
     /// @param substituteClientId The client identifier of the substitute client
     function migrateClient(string calldata subjectClientId, string calldata substituteClientId) external;
 
-    /// @notice Updates the client given the client identifier.
-    /// @param clientId The client identifier
-    /// @param updateMsg The update message
-    /// @return The result of the update operation
-    function updateClient(
-        string calldata clientId,
-        bytes calldata updateMsg
-    )
-        external
-        returns (ILightClientMsgs.UpdateResult);
-
     /// @notice Submits misbehaviour to the client with the given client identifier.
     /// @param clientId The client identifier
     /// @param misbehaviourMsg The misbehaviour message
     function submitMisbehaviour(string calldata clientId, bytes calldata misbehaviourMsg) external;
 
-    /// @notice Upgrades the client with the given client identifier.
-    /// @param clientId The client identifier
-    /// @param upgradeMsg The upgrade message
-    function upgradeClient(string calldata clientId, bytes calldata upgradeMsg) external;
-
     /// @notice Returns the role identifier for a light client
     /// @param clientId The client identifier
     /// @return The role identifier

contracts/utils/ICS02ClientUpgradeable.sol

@@ -1,7 +1,6 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.28;
 
-import { ILightClientMsgs } from "../msgs/ILightClientMsgs.sol";
 import { IICS02ClientMsgs } from "../msgs/IICS02ClientMsgs.sol";
 
 import { IICS02ClientErrors } from "../errors/IICS02ClientErrors.sol";
@@ -151,28 +150,12 @@ abstract contract ICS02ClientUpgradeable is IICS02Client, IICS02ClientErrors, Ac
         emit ICS02ClientMigrated(subjectClientId, substituteClientId);
     }
 
-    /// @inheritdoc IICS02Client
-    function updateClient(
-        string calldata clientId,
-        bytes calldata updateMsg
-    )
-        external
-        returns (ILightClientMsgs.UpdateResult)
-    {
-        return getClient(clientId).updateClient(updateMsg);
-    }
-
     /// @inheritdoc IICS02Client
     function submitMisbehaviour(string calldata clientId, bytes calldata misbehaviourMsg) external {
         getClient(clientId).misbehaviour(misbehaviourMsg);
         emit ICS02MisbehaviourSubmitted(clientId, misbehaviourMsg);
     }
 
-    /// @inheritdoc IICS02Client
-    function upgradeClient(string calldata clientId, bytes calldata upgradeMsg) external {
-        getClient(clientId).upgradeClient(upgradeMsg);
-    }
-
     /// @notice Returns the storage of the ICS02Client contract
     function _getICS02ClientStorage() private pure returns (ICS02ClientStorage storage $) {
         // solhint-disable-next-line no-inline-assembly

packages/go-abigen/ics26router/contract.go

@@ -80,13 +80,6 @@ contract ICS02ClientTest is Test {
         ics02Client.addClient(customClientId, counterpartyInfo, address(lightClient));
     }
 
-    function test_UpdateClient() public {
-        bytes memory updateMsg = "testUpdateMsg";
-        ILightClientMsgs.UpdateResult updateResult = ics02Client.updateClient(clientIdentifier, updateMsg);
-        assertEq(uint256(updateResult), uint256(ILightClientMsgs.UpdateResult.Update), "updateClient failed");
-        assertEq(updateMsg, lightClient.latestUpdateMsg(), "updateClient failed");
-    }
-
     function test_MigrateClient() public {
         address bob = makeAddr("bob");
 
@@ -134,9 +127,4 @@ contract ICS02ClientTest is Test {
         bytes memory misbehaviourMsg = "testMisbehaviourMsg";
         ics02Client.submitMisbehaviour(clientIdentifier, misbehaviourMsg);
     }
-
-    function test_UpgradeClient() public {
-        bytes memory upgradeMsg = "testUpgradeMsg";
-        ics02Client.upgradeClient(clientIdentifier, upgradeMsg);
-    }
 }