Skip to content

Commit 243ccc1

Browse files
chore: minor cleanup (backport #487) (#490)
Co-authored-by: Gjermund Garaba <gjermund@garaba.net>
1 parent a1ed92d commit 243ccc1

File tree

3 files changed

+16
-25
lines changed

3 files changed

+16
-25
lines changed

e2e/interchaintestv8/ibc_eureka_test.go

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -393,13 +393,11 @@ func (s *IbcEurekaTestSuite) DeployTest(ctx context.Context, proofType operator.
393393
})
394394
s.Require().NoError(err)
395395

396-
// TODO: https://github.com/cosmos/ibc-go/issues/7875
397-
// channelResp, err := e2esuite.GRPCQuery[channeltypesv2.QueryChannelResponse](ctx, simd, &channeltypesv2.QueryChannelRequest{
398-
// ChannelId: ibctesting.FirstChannelID,
399-
// })
400-
// s.Require().NoError(err)
401-
// s.Require().Equal(testvalues.FirstWasmClientID, channelResp.Channel.ClientId)
402-
// s.Require().Equal(testvalues.CustomClientID, channelResp.Channel.CounterpartyChannelId)
396+
counterpartyInfoResp, err := e2esuite.GRPCQuery[clienttypesv2.QueryCounterpartyInfoResponse](ctx, simd, &clienttypesv2.QueryCounterpartyInfoRequest{
397+
ClientId: testvalues.FirstWasmClientID,
398+
})
399+
s.Require().NoError(err)
400+
s.Require().Equal(testvalues.CustomClientID, counterpartyInfoResp.CounterpartyInfo.ClientId)
403401
}))
404402

405403
s.Require().True(s.Run("Verify Cosmos to Eth Relayer Info", func() {

e2e/interchaintestv8/multichain_test.go

Lines changed: 10 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -550,13 +550,11 @@ func (s *MultichainTestSuite) TestDeploy_Groth16() {
550550
})
551551
s.Require().NoError(err)
552552

553-
// TODO: https://github.com/cosmos/ibc-go/issues/7875
554-
// channelResp, err := e2esuite.GRPCQuery[channeltypesv2.QueryChannelResponse](ctx, simdA, &channeltypesv2.QueryChannelRequest{
555-
// ChannelId: ibctesting.FirstChannelID,
556-
// })
557-
// s.Require().NoError(err)
558-
// s.Require().Equal(testvalues.FirstWasmClientID, channelResp.Channel.ClientId)
559-
// s.Require().Equal(testvalues.FirstUniversalClientID, channelResp.Channel.CounterpartyChannelId)
553+
counterpartyInfoResp, err := e2esuite.GRPCQuery[clienttypesv2.QueryCounterpartyInfoResponse](ctx, simdA, &clienttypesv2.QueryCounterpartyInfoRequest{
554+
ClientId: testvalues.FirstWasmClientID,
555+
})
556+
s.Require().NoError(err)
557+
s.Require().Equal(testvalues.FirstUniversalClientID, counterpartyInfoResp.CounterpartyInfo.ClientId)
560558
}))
561559

562560
s.Require().True(s.Run("Verify ethereum light client for SimdB", func() {
@@ -565,13 +563,11 @@ func (s *MultichainTestSuite) TestDeploy_Groth16() {
565563
})
566564
s.Require().NoError(err)
567565

568-
// TODO: https://github.com/cosmos/ibc-go/issues/7875
569-
// channelResp, err := e2esuite.GRPCQuery[channeltypesv2.QueryChannelResponse](ctx, simdB, &channeltypesv2.QueryChannelRequest{
570-
// ChannelId: ibctesting.FirstChannelID,
571-
// })
572-
// s.Require().NoError(err)
573-
// s.Require().Equal(testvalues.FirstWasmClientID, channelResp.Channel.ClientId)
574-
// s.Require().Equal(ibctesting.SecondClientID, channelResp.Channel.CounterpartyChannelId)
566+
counterpartyInfoResp, err := e2esuite.GRPCQuery[clienttypesv2.QueryCounterpartyInfoResponse](ctx, simdB, &clienttypesv2.QueryCounterpartyInfoRequest{
567+
ClientId: testvalues.FirstWasmClientID,
568+
})
569+
s.Require().NoError(err)
570+
s.Require().Equal(testvalues.SecondUniversalClientID, counterpartyInfoResp.CounterpartyInfo.ClientId)
575571
}))
576572

577573
s.Require().True(s.Run("Verify Light Client of Chain A on Chain B", func() {
@@ -1137,9 +1133,6 @@ func (s *MultichainTestSuite) TestTransferEthToCosmosToCosmosAndBack_Groth16() {
11371133
timeout := uint64(time.Now().Add(30 * time.Minute).Unix())
11381134

11391135
transferPayload := transfertypes.FungibleTokenPacketData{
1140-
// Denom: denomOnSimdA.IBCDenom(),
1141-
// BUG: Allowing user to choose the above is a bug in ibc-go
1142-
// https://github.com/cosmos/ibc-go/issues/7848
11431136
Denom: denomOnSimdA.Path(),
11441137
Amount: transferAmount.String(),
11451138
Sender: simdAUser.FormattedAddress(),

programs/relayer/src/modules/eth_to_cosmos.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ impl RelayerService for EthToCosmosRelayerModuleService {
199199
&self,
200200
request: Request<api::CreateClientRequest>,
201201
) -> Result<Response<api::CreateClientResponse>, tonic::Status> {
202-
tracing::info!("Handling relay by tx request for Eth to Cosmos...");
202+
tracing::info!("Handling create client request for Eth to Cosmos...");
203203

204204
let inner_req = request.into_inner();
205205
let tx = self

0 commit comments

Comments
 (0)