Skip to content

Reset button puts you back at the Sun #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Reset button puts you back at the Sun #75

wants to merge 3 commits into from

Conversation

johnarban
Copy link
Contributor

Fixes #74. Reset button puts you back at the sun just before sunset.

@johnarban johnarban requested a review from patudom March 11, 2025 20:12
@patudom
Copy link
Contributor

patudom commented Mar 11, 2025

Definitely an improvement - thank you! I pushed a commit to switch the positions of the home & detailed time control buttons.

A few other issues I noticed:

  • if you advance to a future day, the "home" button takes you to the correct time on that future day. I would expect it to use "today."
Screenshot 2025-03-11 at 5 07 07 PM
  • We moved the time controls to the middle for both mobile & desktop at some point, but we forgot to also move the detailed time controls dialog.
Screenshot 2025-03-11 at 5 18 19 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patudom patudom Awaiting requested review from patudom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reset button should also put you back at the Sun.
2 participants
@johnarban @patudom