Skip to content

Commit 2923c16

Browse files
authored
Fix default logic for dependencies field (#6)
1 parent f56d349 commit 2923c16

File tree

2 files changed

+8
-16
lines changed

2 files changed

+8
-16
lines changed

nucleus/generate.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -58,16 +58,12 @@ def validate_config(config: dict):
5858
config["max_concurrency"] = 0
5959

6060
if "dependencies" not in config:
61-
config["dependencies"] = {
62-
"pip": "requirements.txt",
63-
"conda": "conda-packages.txt",
64-
"shell": "dependencies.sh",
65-
}
66-
elif "pip" not in config["dependencies"]:
61+
config["dependencies"] = {}
62+
if "pip" not in config["dependencies"]:
6763
config["dependencies"]["pip"] = "requirements.txt"
68-
elif "conda" not in config["dependencies"]:
64+
if "conda" not in config["dependencies"]:
6965
config["dependencies"]["conda"] = "conda-packages.txt"
70-
elif "shell" not in config["dependencies"]:
66+
if "shell" not in config["dependencies"]:
7167
config["dependencies"]["shell"] = "dependencies.sh"
7268

7369
if "server_side_batching" in config:

src/cortex/init/expand_server_config.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -50,16 +50,12 @@ def main(model_server_config_path: str):
5050
server_config["max_concurrency"] = 0
5151

5252
if "dependencies" not in server_config:
53-
server_config["dependencies"] = {
54-
"pip": "requirements.txt",
55-
"conda": "conda-packages.txt",
56-
"shell": "dependencies.sh",
57-
}
58-
elif "pip" not in server_config["dependencies"]:
53+
server_config["dependencies"] = {}
54+
if "pip" not in server_config["dependencies"]:
5955
server_config["dependencies"]["pip"] = "requirements.txt"
60-
elif "conda" not in server_config["dependencies"]:
56+
if "conda" not in server_config["dependencies"]:
6157
server_config["dependencies"]["conda"] = "conda-packages.txt"
62-
elif "shell" not in server_config["dependencies"]:
58+
if "shell" not in server_config["dependencies"]:
6359
server_config["dependencies"]["shell"] = "dependencies.sh"
6460

6561
if "python_path" not in server_config:

0 commit comments

Comments
 (0)