Skip to content

Conversation

daker
Copy link
Contributor

@daker daker commented Oct 16, 2025

This pull request primarily updates the dependency on @kitware/vtk.js to version 34.13.2 across multiple packages and refines rendering configuration handling in the core rendering engine. The most significant impact is improved compatibility with the latest VTK.js and more consistent usage of the preferSizeOverAccuracy rendering option.

Dependency Updates

  • Updated @kitware/vtk.js dependency to version 34.13.2 in packages/core/package.json, packages/labelmap-interpolation/package.json, and packages/polymorphic-segmentation/package.json for improved compatibility and access to new features. [1] [2] [3]

Rendering Configuration Improvements

  • Added explicit usage of getConfiguration().rendering.preferSizeOverAccuracy in createVolumeActor.ts to set the rendering accuracy for volume actors, ensuring consistent behavior. [1] [2]
  • Removed the conditional setting of preferSizeOverAccuracy in createVolumeMapper.ts and StackViewport.ts, centralizing configuration logic and reducing redundant code. [1] [2]

Internal API Consistency

  • Refactored the vtkStreamingOpenGLTexture.js API to accept parameters as an object instead of positional arguments, improving readability and maintainability.

Minor Code Consistency

  • Standardized string quotes in version.ts for consistency.

@sedghi
Copy link
Member

sedghi commented Oct 18, 2025

let's see tests passing or not, there seem to be some build errors though

$ tsc --project ./tsconfig.json
src/cache/classes/Mesh.ts:61:15 - error TS2339: Property 'setInputConnection' does not exist on type 'Readonly<{}>'.

61       normals.setInputConnection(reader.getOutputPort());
                 ~~~~~~~~~~~~~~~~~~

src/cache/classes/Mesh.ts:62:41 - error TS2339: Property 'getOutputPort' does not exist on type 'Readonly<{}>'.

62       mapper.setInputConnection(normals.getOutputPort());
                                           ~~~~~~~~~~~~~

src/RenderingEngine/renderPasses/sharpeningRenderPass.ts:19:21 - error TS2339: Property 'setDelegates' does not exist on type 'Readonly<{}>'.

19     convolutionPass.setDelegates([renderPass]);
                       ~~~~~~~~~~~~

src/RenderingEngine/renderPasses/sharpeningRenderPass.ts:27:21 - error TS2339: Property 'setKernelDimension' does not exist on type 'Readonly<{}>'.

27     convolutionPass.setKernelDimension(3);
                       ~~~~~~~~~~~~~~~~~~

src/RenderingEngine/renderPasses/sharpeningRenderPass.ts:28:21 - error TS2339: Property 'setKernel' does not exist on type 'Readonly<{}>'.

28     convolutionPass.setKernel([-k, -k, -k, -k, 1 + 8 * k, -k, -k, -k, -k]);
                       ~~~~~~~~~

also i'm not sure why we are removing preferSizeOverAccuracy? does that not work anymore in 34?

…multi-input volumes

- Added logic to determine the number of components based on valid inputs.
- Updated the use of independent components based on volume properties for multi-component data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants