Skip to content

Conversation

IbrahimCSAE
Copy link
Collaborator

Context

using default values to decide if pixel spacing is present is wrong, cuz it gets set to true when other fields are not present that are not pixel spacing

@wayfarer3130
Copy link
Collaborator

Can you link with OHIF and test:

  • US region spacing
  • ERMF spacing types
  • Calibrated spacing on uncalibrated data and on re-calibrated data

@wayfarer3130
Copy link
Collaborator

Probably adding a set of integration tests for the various cases is important. The using default values is supposed to get set when there are no pixel spacing measures at all to use, and is supposed to not be set when there is some sort of pixel spacing measures to use. Ideally using the enum flag for that would be better - that flag indicates the type of spacing.
It probably shouldn't also be the viewport's decision on spacing - that is really a function of the annotation position interacting with the metadata values. The viewport only cares about spacing so that if it is displaying true size it knows the correct size to use. Really, I'd like a change in the tools that does not rely on the viewport for that.

@IbrahimCSAE
Copy link
Collaborator Author

Can you link with OHIF and test:

  • US region spacing
  • ERMF spacing types
  • Calibrated spacing on uncalibrated data and on re-calibrated data

I will do and post results, I can write a test as well for all the types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants