Feat(coordinate mapping) #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

wayfarer3130 merged 6 commits into cornerstonejs:main from rodrigobasilio2022:feat(coordinate-mapping)

May 27, 2025

+94 −39

Contributor

rodrigobasilio2022 commented May 7, 2025 •

edited

Loading

Context

Changes & Results

Fixed coordinate conversions between slide coordinate system, image/pixel/index coordinates and canvas coordinates.

Given the points 1, 2 and 3

#	Point (World Coordinates)	Expected Canvas Result	CS3D Canvas Result	Difference
1	[5, 25, 0]	[0, 74.02]	[0, 778]	[0, +703.98]
2	[12.5, 32.5, 0]	[250, 250]	[250, 602]	[0, +352]
3	[20, 40, 0]	[500, 426.02]	[500, 426.02]	[0, 0]

Also we implement the indexToWorld and worldToIndex functions

Testing

Checklist

PR

[] My Pull Request title is descriptive, accurate and follows the
semantic-release format and guidelines.

Code

[] My code has been well-documented (function documentation, inline comments,
etc.)

Public Documentation Updates

[] The documentation page has been updated as necessary for any public API
additions or removals.

Tested Environment

[] "OS:
[] "Node version:
[] "Browser:

rodrigobasilio2022 added 2 commits

May 7, 2025 08:09


          fix(coordinates): fix wsi coordinate mapping

e192e6d


          Merge branch 'main' into feat(coordinate-mapping)

ad8b433

rodrigobasilio2022 changed the title ~~[WIP] Feat(coordinate mapping)~~ Feat(coordinate mapping)

wayfarer3130 reviewed

View reviewed changes

packages/core/src/RenderingEngine/WSIViewport.ts Show resolved Hide resolved

wayfarer3130 reviewed

View reviewed changes

packages/core/src/RenderingEngine/WSIViewport.ts Show resolved Hide resolved

rodrigobasilio2022 added 3 commits

May 7, 2025 10:42


          fix function signature

3fdac7b


          REmoving -1 multiplication i Y axis

c162369


          Add flipping in index conversions

919be4d

wayfarer3130 reviewed

View reviewed changes

packages/core/src/RenderingEngine/WSIViewport.ts Outdated Show resolved Hide resolved

wayfarer3130 reviewed

View reviewed changes

packages/core/src/RenderingEngine/WSIViewport.ts Outdated Show resolved Hide resolved

wayfarer3130 reviewed

View reviewed changes

packages/core/src/RenderingEngine/WSIViewport.ts Outdated Show resolved Hide resolved

wayfarer3130 requested changes

View reviewed changes

Collaborator

wayfarer3130 left a comment

Couple of small changes and then I can merge.

sedghi reviewed

View reviewed changes

Member

sedghi left a comment

Please update the description to explain what's currently wrong or what this unlocks.


          apply review suggestions

24332e7

rodrigobasilio2022 requested review from wayfarer3130 and sedghi

May 8, 2025 15:08

sedghi approved these changes

View reviewed changes

Contributor Author

rodrigobasilio2022 commented May 9, 2025 •

edited

Loading

@wayfarer3130 I think you approve on the wrong place...

wayfarer3130 approved these changes

View reviewed changes

wayfarer3130 merged commit fe23258 into cornerstonejs:main

9 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet