-
Notifications
You must be signed in to change notification settings - Fork 384
fix(labelmap) : Display labelmap on volume3d viewport #1993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(labelmap) : Display labelmap on volume3d viewport #1993
Conversation
…to renderlabelmap-for-3dviewport
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…into renderlabelmap-for-3dviewport
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is what happens on the real 3D viewport, since we don't want to render Labelmap in 3D viewport, the best representation for segmentation in 3D viewport is actually a surface
But actually it works pretty well even in 3D viewport, maybe @Celian-abd you can make a video of the cornerstone example with 3D viewport with labelmap? |
yes please, let's see. Create couple of segments that overlap if camera looks at them from different angles |
Hum overlap I'm not sure, however not la elmap have overlap, it can be a known limitation of this rendering that fit several use cases |
but is that a 3d viewport or a mip viewport? |
It's a volume3D viewport
|
can you pull main, i fixed the tests |
…into renderlabelmap-for-3dviewport
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This requires a lot more testing from me, it will take some time sorry
Context
The labelmap was showing on mip using volume or orthographic viewport but it was not working for volume3d.
Changes & Results
This changes allow the labelmap to render on volume3d viewport aswell as volume.
Testing
Can be tested in the labelmapMIP example.
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment