refactor(Tools): Cleanup code for drawingSvg, make 'data-id' attribut… #1952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sedghi
reviewed
Mar 30, 2025
sedghi
reviewed
Mar 30, 2025
Comment on lines
+5
to
+12
| function _draw( | ||
| what: 'circle' | 'line' | 'ellipse' | 'rect' | 'path' | 'polyline' | 'g', | ||
| svgDrawingHelper: SVGDrawingHelper, | ||
| annotationUID: string, | ||
| drawingId: string, | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| attributes: Record<string, any> | ||
| ): { |
There was a problem hiding this comment.
Can you use an object instead of positional parameters?
There was a problem hiding this comment.
over my dead body ;-). this is typically over engineering in my opinion.
( we are talking of 5 positional arguments that fit into a single line of text in most cases )
There was a problem hiding this comment.
The issue is, later on, we're developing another tool that needs to use the _draw, but for some weird reason, it doesn't actually need drawingId or whatever. Then we end up using _draw like this:
_draw(null, svgDrawingHelper, null, ...)
I hope that makes sense.
sedghi
reviewed
Mar 30, 2025
sedghi
reviewed
Mar 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e consistant
Context
When adding svg annotation, there is a custom attribute 'data-id' intended for automation test.
the feature was not consistently implemented ( most of the time missing ) and is somehow redundant with internal unique id.
This PR remove custom value for data-id and uses the internal uid.
Changes & Results
only impacts 'data-id' attribute in SVG elements.
Testing
use stack annotation tools / https://www.cornerstonejs.org/live-examples/stackannotationtools
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment