Skip to content

feat(torch): Build with AOCL-BLAS and AOCL-LAPACK, and HPC-X v2.19 #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 29, 2024
Merged

feat(torch): Build with AOCL-BLAS and AOCL-LAPACK, and HPC-X v2.19 #68

merged 4 commits into from
May 29, 2024

Conversation

Eta0
Copy link
Collaborator

@Eta0 Eta0 commented May 29, 2024

BLAS & LAPACK

This change adds AOCL-BLAS & AOCL-LAPACK as lightweight AMD-optimized alternatives to MKL for CPU linear algebra. Previously, no BLAS or LAPACK implementations were included.

This additionally updates the nccl-tests base images for torch:nccl to use HPC-X v2.19, as added in coreweave/nccl-tests#38.

@Eta0 Eta0 added the enhancement New feature or request label May 29, 2024
@Eta0 Eta0 requested a review from wbrown May 29, 2024 03:39
@Eta0 Eta0 self-assigned this May 29, 2024
@github-actions GitHub Actions
Copy link

@Eta0 Build complete, success: https://github.com/coreweave/ml-containers/actions/runs/9280740219
Image: ghcr.io/coreweave/ml-containers/nightly-torch:es-blas-79b3cb5-nccl-24052905-cuda12.0.1-ubuntu22.04-nccl2.18.5-1-torch2.4.0a0-vision0.19.0a0-audio2.2.0a0

@github-actions GitHub Actions
Copy link

@Eta0 Build complete, success: https://github.com/coreweave/ml-containers/actions/runs/9280740219
Image: ghcr.io/coreweave/ml-containers/nightly-torch:es-blas-79b3cb5-nccl-24052905-cuda12.0.1-ubuntu20.04-nccl2.19.3-1-torch2.4.0a0-vision0.19.0a0-audio2.2.0a0

@github-actions GitHub Actions
Copy link

@Eta0 Build complete, success: https://github.com/coreweave/ml-containers/actions/runs/9280740219
Image: ghcr.io/coreweave/ml-containers/nightly-torch:es-blas-79b3cb5-nccl-24052905-cuda11.8.0-ubuntu20.04-nccl2.16.5-1-torch2.4.0a0-vision0.19.0a0-audio2.2.0a0

@github-actions GitHub Actions
Copy link

@Eta0 Build complete, success: https://github.com/coreweave/ml-containers/actions/runs/9280740219
Image: ghcr.io/coreweave/ml-containers/nightly-torch:es-blas-79b3cb5-nccl-24052905-cuda12.1.1-ubuntu20.04-nccl2.18.3-1-torch2.4.0a0-vision0.19.0a0-audio2.2.0a0

@github-actions GitHub Actions
Copy link

@Eta0 Build complete, success: https://github.com/coreweave/ml-containers/actions/runs/9280740219
Image: ghcr.io/coreweave/ml-containers/nightly-torch:es-blas-79b3cb5-nccl-24052905-cuda12.1.1-ubuntu22.04-nccl2.18.3-1-torch2.4.0a0-vision0.19.0a0-audio2.2.0a0

@github-actions GitHub Actions
Copy link

@Eta0 Build complete, success: https://github.com/coreweave/ml-containers/actions/runs/9280740219
Image: ghcr.io/coreweave/ml-containers/nightly-torch:es-blas-79b3cb5-nccl-24052905-cuda12.2.2-ubuntu20.04-nccl2.21.5-1-torch2.4.0a0-vision0.19.0a0-audio2.2.0a0

@github-actions GitHub Actions
Copy link

@Eta0 Build complete, success: https://github.com/coreweave/ml-containers/actions/runs/9280740219
Image: ghcr.io/coreweave/ml-containers/nightly-torch:es-blas-79b3cb5-nccl-24052905-cuda12.2.2-ubuntu22.04-nccl2.19.3-1-torch2.4.0a0-vision0.19.0a0-audio2.2.0a0

@github-actions GitHub Actions
Copy link

@Eta0 Build complete, success: https://github.com/coreweave/ml-containers/actions/runs/9280740219
Image: ghcr.io/coreweave/ml-containers/nightly-torch:es-blas-79b3cb5-base-24052905-cuda12.0.1-ubuntu20.04-torch2.4.0a0-vision0.19.0a0-audio2.2.0a0

@github-actions GitHub Actions
Copy link

@Eta0 Build complete, success: https://github.com/coreweave/ml-containers/actions/runs/9280740219
Image: ghcr.io/coreweave/ml-containers/nightly-torch:es-blas-79b3cb5-base-24052905-cuda11.8.0-ubuntu20.04-torch2.4.0a0-vision0.19.0a0-audio2.2.0a0

@github-actions GitHub Actions
Copy link

@Eta0 Build complete, success: https://github.com/coreweave/ml-containers/actions/runs/9280740219
Image: ghcr.io/coreweave/ml-containers/nightly-torch:es-blas-79b3cb5-base-24052905-cuda12.0.1-ubuntu22.04-torch2.4.0a0-vision0.19.0a0-audio2.2.0a0

wbrown
wbrown approved these changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@wbrown wbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lordy. 👍

@wbrown wbrown merged commit acd3ada into main May 29, 2024
36 of 63 checks passed
@wbrown wbrown deleted the es/blas branch May 29, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbrown wbrown wbrown approved these changes

Assignees

@Eta0 Eta0

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eta0 @wbrown