-
Notifications
You must be signed in to change notification settings - Fork 5
feat(torch): Updates & Stability Fixes #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbrown
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job. I especially like the stability improvements to the build process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates for PyTorch, Apex, DeepSpeed, Flash Attention, and
nccl-tests
Base Images, Fix for Triton intorch-nightly
, and Caching ImprovementsWhat a mouthful of a title!
Updates
This change contains the following library version updates:
torch
: 2.2.2 → 2.3.0vision
: 0.17.2 → 0.18.0audio
: 2.2.2 → 2.3.0apex
:2386a91
→a7de60e
deepspeed
: 0.12.6 → 0.14.2flash_attn
: 2.4.2 → 2.5.8numpy
: The latest release ofnumpy
is installed alongside alltorch
builds. Previously, only thepython3-numpy
package from the Ubuntu distribution in use was included in the finaltorch
images.Additionally, the
torch:nccl
build with Ubuntu 20.04 × CUDA 12.2.2 now uses an updated base image featuring NCCL v2.21.5-1Stability
torch
build are now retried after a random delay instead of cancelling the build run.torch
builds, instead of all CPUs.torch
, to better catch storage issues during CI.Fixes
triton
compiled from source is now included withtorch-nightly
builds, since customtriton
source commits are used during PyTorch development that are not necessarily compatible with the distributed versions available through package managers.deepspeed
included intorch-extras
has had ahead-of-time compilation for itsCCL_COMM
op disabled to be able to compile without oneCCL installed.Performance
ml-containers
build workflow now accepts an optionalcache-key
argument for more granular caching.cache-key
andimage-name
parameters are used together to form a complete cache key for a given image.torch
/torch-extras
/nightly-torch
/nightly-torch-extras
image flavours (corresponding to their base images) now use different cache keys.ccache
cache size was increased to 5 GiB.