Skip to content

Conversation

@fzipi
Copy link
Member

@fzipi fzipi commented Nov 20, 2022

Signed-off-by: Felipe Zipitria felipe.zipitria@owasp.org

Modify logger to output in a format parseable by Github's runners.

Fixes #56.

Pending:

  • add tests on output

@fzipi fzipi force-pushed the add-github-zerolog-output branch 2 times, most recently from c343cf2 to f2418cf Compare February 27, 2024 20:22
@fzipi fzipi force-pushed the add-github-zerolog-output branch from 9eaefbd to 9ea579c Compare March 1, 2024 11:58
@fzipi
Copy link
Member Author

fzipi commented Mar 1, 2024

Moved commit 9ea579c to #122.

@fzipi fzipi force-pushed the add-github-zerolog-output branch from 8891875 to 932d12b Compare March 2, 2024 17:43
@fzipi fzipi marked this pull request as ready for review March 2, 2024 17:43
@fzipi fzipi requested a review from theseion March 2, 2024 17:43
@fzipi
Copy link
Member Author

fzipi commented Mar 2, 2024

@theseion Looks like test is failing (cmd/regex_compare_test.go:151) because the error was not triggered per if rootValues.output == gitHub... so probably we want to change the test?

@fzipi fzipi force-pushed the add-github-zerolog-output branch from 932d12b to 58bbb52 Compare March 2, 2024 20:47
Copy link
Contributor

@theseion theseion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

fzipi added 2 commits August 14, 2025 19:32
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi fzipi force-pushed the add-github-zerolog-output branch from eda978b to 7422dfa Compare August 14, 2025 22:35
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi fzipi force-pushed the add-github-zerolog-output branch from 7422dfa to 43331f6 Compare August 14, 2025 22:37
@fzipi fzipi requested a review from theseion August 14, 2025 22:38
text: "this is a warning message",
logType: zerolog.WarnLevel,
want: "::warn ::this is a warning message",
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test for error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use configurable output, not the logger

3 participants