fix: meta character escaping #252
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzipi
approved these changes
Aug 9, 2025
theseion
force-pushed
the
fix-meta-character-escaping
branch
from
438083d to
1d8bcaa
Compare
The cmdline processor treats each line of input as a string, not a regular rexpression. However, the assembler treats input as regular expressions. The output of the cmdline processor must, therefore, be properly escaped. The function responsible for handling escape sequences was missing the `+` character, causing literal `+` characters to end up being passed to the assembler.
theseion
force-pushed
the
fix-meta-character-escaping
branch
from
426d626 to
8c2d84c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cmdline processor treats each line of input as a string, not a regular rexpression. However, the assembler treats input as regular expressions. The output of the cmdline processor must, therefore, be properly escaped.
The function responsible for handling escape sequences was missing the
+character, causing literal+characters to end up being passed to the assembler.