Skip to content

Conversation

@n3ziniuka5
Copy link

@n3ziniuka5 n3ziniuka5 commented Nov 5, 2025

Description

Allows the AWS resource catalog integration to pull metadata from RDS instances, Lambda functions, EBS columes, and S3 buckets

Fixes:

How Has This Been Tested?

Deployed the stack to research account and then ran cloud-collector locally to verify that the new permissions are enough for the infra explorer.

Checklist:

  • I have updated the relevant component changelog(s)
  • This change does not affect any particular component (e.g. it's readme or docs change)

@n3ziniuka5 n3ziniuka5 requested a review from a team as a code owner November 5, 2025 10:09
@CLAassistant
Copy link

CLAassistant commented Nov 5, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@n3ziniuka5 n3ziniuka5 marked this pull request as draft November 5, 2025 10:12
@n3ziniuka5 n3ziniuka5 marked this pull request as ready for review November 5, 2025 10:12
@n3ziniuka5 n3ziniuka5 force-pushed the feat/aws-catalog-rds branch from cf52a7e to e9877b8 Compare November 5, 2025 10:12
@n3ziniuka5 n3ziniuka5 marked this pull request as draft November 7, 2025 08:27
@n3ziniuka5 n3ziniuka5 marked this pull request as ready for review November 7, 2025 08:27
@n3ziniuka5 n3ziniuka5 force-pushed the feat/aws-catalog-rds branch from e9877b8 to b81ead0 Compare November 7, 2025 08:27
@n3ziniuka5 n3ziniuka5 changed the title feat: add RDS permissions for infrastructure explorer feat: add RDS/Lambda/EBS permissions for infrastructure explorer Nov 7, 2025
dmenilo1
dmenilo1 previously approved these changes Nov 9, 2025
Copy link
Contributor

@dmenilo1 dmenilo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmenilo1 dmenilo1 self-requested a review November 9, 2025 10:24
@dmenilo1 dmenilo1 dismissed their stale review November 9, 2025 10:25

Noticed this should not be merged

@n3ziniuka5 n3ziniuka5 marked this pull request as draft November 11, 2025 16:05
@n3ziniuka5 n3ziniuka5 marked this pull request as ready for review November 11, 2025 16:05
@n3ziniuka5 n3ziniuka5 changed the title feat: add RDS/Lambda/EBS permissions for infrastructure explorer feat: add RDS/Lambda/EBS/S3 permissions for infrastructure explorer Nov 11, 2025
@n3ziniuka5 n3ziniuka5 marked this pull request as draft November 11, 2025 16:07
@n3ziniuka5 n3ziniuka5 marked this pull request as ready for review November 11, 2025 16:07
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants