Skip to content

Conversation

@favourch
Copy link

Changes

  • Replace x-forms.select with x-forms.datalist for the repository picker in resources/views/livewire/project/new/github-private-repository.blade.php.
  • Enable type-to-search filtering via Alpine.js while preserving wire:model.live="selected_repository_id".
  • Maintain existing layout and Livewire behavior; no backend changes required.

Issues

  • N/A - improvement noticed during usage and added proactively.

Testing

  • Verified repository list filters as you type.
  • Ensured selection updates selected_repository_id and “Load Repository” continues to work.

andrasbacsai and others added 4 commits October 29, 2025 10:39
- Replace x-forms.select with x-forms.datalist for repository picker
- Enable type-to-filter UX with Alpine.js, keeping Livewire binding
- Update in resources/views/livewire/project/new/github-private-repository.blade.php
Copy link
Member

@ShadowArcanist ShadowArcanist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the target branch to NEXT instead of v4.x and did you manually test your changes?

@ShadowArcanist ShadowArcanist added the 💤 Waiting for changes PRs awaiting changes from the author. label Oct 31, 2025
@favourch
Copy link
Author

favourch commented Nov 1, 2025 via email

@favourch favourch changed the base branch from v4.x to next November 1, 2025 04:44
Copy link
Author

@favourch favourch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShadowArcanist I've updated the target branch from v4.x to next as requested.

The changes remain the same:

  • Replaced x-forms.select with x-forms.datalist for searchable repository selection
  • All functionality preserved with improved UX

Ready for review!

@ShadowArcanist
Copy link
Member

@CodeRabbit review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 1, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 1, 2025

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (2)
  • Rabbit
  • 🐰 Release The Rabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Summary by CodeRabbit

  • New Features

    • Added search functionality to the GitHub private repository selector for easier repository discovery and selection.
  • Service Updates

    • Updated deployment configurations for multiple services including Activepieces, Beszel, Bluesky-PDS, and Certbot to improve compatibility and reliability.

Walkthrough

A Blade template refactors the GitHub repository selector from a <select> to a <datalist> component with live model binding, while service template JSON configurations receive updated base64-encoded Docker Compose definitions across multiple service entries.

Changes

Cohort / File(s) Summary
UI Component Refactoring
resources/views/livewire/project/new/github-private-repository.blade.php
Converted repository selector from <select> element to <datalist> component; updated wire binding from wire:model to wire:model.live; simplified option rendering logic; added "Search repositories..." placeholder
Service Template Configuration Updates
templates/service-templates-latest.json, templates/service-templates.json
Updated base64-encoded Docker Compose strings for multiple service entries (activepieces, beszel, bluesky-pds, certbot, and others); changes affect deployment configurations and runtime orchestration behavior

Sequence Diagram(s)

sequenceDiagram
    actor User
    participant Datalist as Datalist Component
    participant Livewire as Livewire (wire:model.live)
    
    User->>Datalist: Type to search repositories
    Datalist->>Livewire: Emit live input changes
    Livewire->>Datalist: Update available options
    Datalist->>User: Display filtered repositories
    User->>Datalist: Select repository
    Datalist->>Livewire: Commit selection
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Blade template change: Straightforward UI component swap with consistent wire binding pattern
  • JSON updates: Data-driven configuration replacements; requires spot-checking that base64 strings decode properly and represent valid Docker Compose configurations
  • Verify datalist accessibility and search functionality work as intended
  • Validate a few decoded compose strings from the service templates to ensure they're properly formed YAML/configuration

I'll be back... to deploy these configs on a proper self-hosted server, not some serverless nonsense that VC firms dreamed up to extract your cash. At least you can SSH into a real machine and grab a gluten-free taco while your infrastructure actually runs instead of spinning up cold lambdas. 🌮

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "Feat/GitHub Make GitHub repository dropdown searchable in new app flow" directly aligns with the primary change documented in the raw summary: replacing a static select element with a searchable datalist component for the GitHub repository picker. The title is specific, concise, and clearly communicates the feature addition without vague terminology. This is a solid, focused title that a teammate scanning the git history would immediately understand.
Description Check ✅ Passed The pull request description includes both required sections from the template: a detailed Changes section listing the key modifications (datalist replacement, Alpine.js integration, wire:model.live preservation) and an Issues section appropriately marked as N/A with context. The author has correctly removed the submission checklist as instructed by the template. Additionally, a Testing section demonstrates that the changes were validated for filtering behavior and Livewire integration, providing confidence in the implementation quality.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Cinzya Cinzya added ✨ Enhancement Issues requesting new features, new services or improvements. UI/UX labels Nov 1, 2025
@ShadowArcanist
Copy link
Member

@ShadowArcanist I've updated the target branch from v4.x to next as requested.

The changes remain the same:

* Replaced `x-forms.select` with `x-forms.datalist` for searchable repository selection

* All functionality preserved with improved UX

Ready for review!

Thanks!

I just tested it and works fine for me!

You have changed services templates on your commit but it's not mentioned on your commit message or in PR description, please revert it (Keep one change per PR, if you like to make changes to service then do a separate PR for it)
image

- Revert changes to templates/service-templates.json and templates/service-templates-latest.json
- These changes were accidentally included in the repository search dropdown PR
- Service template updates should be in a separate PR
@favourch
Copy link
Author

favourch commented Nov 2, 2025

@ShadowArcanist I've updated reverted the changes committed in error to templates/service-templates.json and templates/service-templates-latest.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ Enhancement Issues requesting new features, new services or improvements. UI/UX 💤 Waiting for changes PRs awaiting changes from the author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants