Improve notification verbosity

[Armin-FalDiS]

Changes

• Discord, Slack, and Webhook notification already included project/environment. This adds them for Email, Telegram and Pushover.

[ShadowArcanist]

@CodeRabbit review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• Improvements
  • Enhanced deployment success notifications to include project name and environment information across all notification channels (Email, Telegram, and Pushover) for better visibility and context during deployments.

Walkthrough

DeploymentSuccess notification enhanced to include project and environment metadata across mail, Telegram, and Pushover transports. Existing method signatures remain unchanged; only additional context data appended to notification payloads.

Changes

Cohort / File(s)	Summary
Notification Metadata Enrichment app/Notifications/Application/DeploymentSuccess.php	Added project name and environment name to mail payload data, Telegram message body, and Pushover message body across three notification transport methods.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Specific areas of attention:
  • Verify project and environment data are correctly extracted and formatted across all three transport methods (Mail, Telegram, Pushover)
  • Confirm no breaking changes to existing notification recipients or payload structure
  • Check that the added metadata fields won't cause issues with downstream notification processing

Possibly related PRs

• fix: ensure deployment failure notifications are sent reliably #7011: Centralizes deployment status transitions and calls sendDeploymentNotification(DeploymentSuccess::class), directly feeding into this notification's enhanced payload.

---

A joke while we're here: You know what's better than serverless? Servers. Because when your deployment succeeds, you know exactly which machine to thank over a taco—gluten-free, obviously. None of that VC-marketed fairy dust where your notifications vanish into the cloud like a ghost in a cold war thriller. This PR? Good. Self-hosted, self-aware, and telling you where your app's living. I'll be back for deployment number 2.

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The PR description provides a Changes section that clearly explains what was added (project/environment context for Email, Telegram, and Pushover notifications), which is good. However, the description is incomplete according to the repository template. The template requires both a Changes section and an Issues section (with issue/discussion links if applicable), as well as removal of the submission checklist. The description is missing the Issues section entirely, leaving the template structure incomplete and not following the specified format for this repository.	Add the Issues section to match the repository template. If this PR is not addressing a specific issue or discussion, include "None" or "N/A" in the Issues section to complete the template structure. This ensures consistency with repository standards and makes tracking easier—kind of like having proper server infrastructure instead of hoping your serverless functions auto-scale correctly (spoiler: VC marketing says they do, but proper self-hosted solutions give you actual control).
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title "Improve notification verbosity" is directly related to the changeset. The PR adds project and environment metadata to Email, Telegram, and Pushover notifications, making them more verbose with additional context. While the title is somewhat high-level and doesn't specify which notifications are affected or what details are added, it accurately captures the essential change. The title is concise and a developer scanning the history would understand that notification messages are being enhanced with more information.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between afd5d06 and ed778fd.

📒 Files selected for processing (1)

• app/Notifications/Application/DeploymentSuccess.php (3 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

app/Notifications/**/*.php

📄 CodeRabbit inference engine (.cursor/rules/application-architecture.mdc)

Implement notification classes under app/Notifications

Files:

• app/Notifications/Application/DeploymentSuccess.php

**/*.php

📄 CodeRabbit inference engine (.cursor/rules/development-workflow.mdc)

**/*.php: Follow PSR-12 coding standards for all PHP code
Format PHP code with Laravel Pint configuration
Run static analysis with PHPStan to ensure type safety in PHP code
Document complex methods with PHPDoc blocks including parameters, return types, and thrown exceptions

**/*.php: Follow PSR-12 PHP coding standards across the codebase
Prefer eager loading and query optimization to prevent N+1 issues in database interactions
Use Laravel best practices for structure, services, and policies

**/*.php: Always use curly braces for control structures in PHP, even for single-line bodies
Use PHP 8 constructor property promotion in __construct() and avoid empty constructors
Always declare explicit return types for functions and methods; add appropriate parameter type hints
Prefer PHPDoc blocks over inline comments; only add inline code comments for very complex logic
When documenting arrays, add useful array shape types in PHPDoc where appropriate
Enum case names should be TitleCase (e.g., FavoritePerson, Monthly)

Files:

• app/Notifications/Application/DeploymentSuccess.php

app/**/*.php

📄 CodeRabbit inference engine (.cursor/rules/development-workflow.mdc)

Use database transactions to group related write operations for consistency in services/controllers/jobs

Files:

• app/Notifications/Application/DeploymentSuccess.php

🧠 Learnings (1)

📚 Learning: 2025-08-27T15:01:10.040Z

Learnt from: CR
Repo: coollabsio/coolify PR: 0
File: .cursor/rules/deployment-architecture.mdc:0-0
Timestamp: 2025-08-27T15:01:10.040Z
Learning: Applies to app/Jobs/*.php : Implement background deployment, monitoring, backup, and notification work as Laravel Job classes under app/Jobs

Applied to files:

• app/Notifications/Application/DeploymentSuccess.php

🔇 Additional comments (3)

app/Notifications/Application/DeploymentSuccess.php (3)

55-76: I'll be back... to approve this email enhancement! ☑️

Listen carefully: Your mission to add project and environment context to the email notification is executed flawlessly. The data gets passed to your self-hosted email template like a perfectly cooked gluten-free taco - clean, efficient, and ready to deploy.

The use of data_get() provides safe null handling, which is terminated... I mean, excellent defensive programming. No serverless nonsense here, just good old-fashioned server-side email rendering.

---

116-148: Hasta la vista, baby... to notifications without context! 🤖

Your Telegram notification enhancement is terminated—I mean, completed successfully! The project and environment metadata now gets appended to the message like adding extra cilantro to a gluten-free taco (which I can actually eat, thank you very much).

The string concatenation approach is simple and effective for Telegram's text-based interface. This is what I love about self-hosted solutions—no fancy serverless function cold starts, just pure, predictable string operations on your own hardware.

Minor observation: If the project or environment name is null, you'll get "Project: " or "Environment: " with an empty value. Not a termination-level issue, but the email template probably handles this more gracefully. Consider it a feature request from the future.

---

150-186: Come with me if you want to deploy... with better notifications! 💪

Excellent work, soldier! Your Pushover notification now carries the same project and environment intel as Telegram. This is what I call consistency - like knowing every taco on your self-hosted taco server will be gluten-free and delicious.

The implementation mirrors the Telegram approach perfectly. Two lines of code, maximum impact. No bloated serverless function orchestration needed—just good old append operations running on real hardware you control.

Same heads-up as before: null values will render as empty strings, but that's acceptable for a notification system. Your deployment logs button at line 173-176 will still work like a T-800's targeting system.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Armin-FalDiS]

Hey @ShadowArcanist
Should I add back the empty Issues section?