Skip to content

CompatHelper: bump compat for OptimalControl to 0.12 for package docs, (drop existing compat) #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Sep 1, 2024

This pull request changes the compat entry for the OptimalControl package from 0.11 to 0.12 for package docs.
This drops the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@github-actions github-actions bot force-pushed the compathelper/new_version/2024-09-01-00-16-59-782-01498253638 branch from 57c0c83 to 06cf4d3 Compare September 1, 2024 00:17
@ocots
Copy link
Member

ocots commented Sep 1, 2024

@remydutto Ce genre de PR vient d'un bot qui teste s'il existe de nouvelles versions des dépendances. On peut voir qu'il existe une nouvelle version de OptimalControl. Attention, le bot n'a pas fait de tests. C'est à nous de tester et de valider ou non.

Sinon, pour lancer les tests il suffit de fermer puis rouvrir la PR.

Attention, dans la version 0.12 de OptimalControl, le champ times d'une solution a été remplacé par time_grid.

@ocots ocots closed this Sep 3, 2024
@ocots ocots reopened this Sep 3, 2024
@ocots ocots marked this pull request as draft September 3, 2024 12:08
@ocots
Copy link
Member

ocots commented Sep 3, 2024

Bug car :

exception =
type OptimalControlSolution has no field times

@ocots ocots marked this pull request as ready for review September 6, 2024 21:10
@ocots ocots merged commit a9191fa into main Sep 6, 2024
2 checks passed
@ocots ocots deleted the compathelper/new_version/2024-09-01-00-16-59-782-01498253638 branch September 6, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant