Skip to content

feat: add support for custom headers in SSE transport #5493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025

Conversation

04cfb1ed
Copy link
Contributor

@04cfb1ed 04cfb1ed commented May 2, 2025

Description

Add support for custom headers in SSE transport, this allows communication with secured servers

closes #5152

@04cfb1ed 04cfb1ed requested a review from a team as a code owner May 2, 2025 22:37
@04cfb1ed 04cfb1ed requested review from sestinj and removed request for a team May 2, 2025 22:37
Copy link

netlify bot commented May 2, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 18832e0
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/6819523b65270800087c9731

@04cfb1ed 04cfb1ed mentioned this pull request May 2, 2025
2 tasks
Copy link
Contributor

@sestinj sestinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@04cfb1ed instead of just the "headers" field, I think we should use the full requestOptions object that exists in index.d.ts (it's already used for models, context providers, and more)

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs May 5, 2025
@04cfb1ed 04cfb1ed force-pushed the feature/add-headers-to-mcp branch from c4883ef to 18832e0 Compare May 6, 2025 00:05
@04cfb1ed
Copy link
Contributor Author

04cfb1ed commented May 6, 2025

The requested changes were done, but one test it's failing with ETIMEDOUT

Installing extensions...
Error while installing extensions: AggregateError [ETIMEDOUT]: 
AggregateError [ETIMEDOUT]: 
Error: Command failed: ELECTRON_RUN_AS_NODE=1 "/home/runner/work/continue/continue/extensions/vscode/e2e/storage/VSCode-linux-x64/code" "/home/runner/work/continue/continue/extensions/vscode/e2e/storage/VSCode-linux-x64/resources/app/out/cli.js" --force --install-extension "ms-vscode-remote.remote-wsl" --extensions-dir=/home/runner/work/continue/continue/extensions/vscode/e2e/.test-extensions

From here #4866 (comment), I understand that the error is not from the new code

(I have the same error in #5517 but in another test)

@04cfb1ed 04cfb1ed requested a review from sestinj May 7, 2025 00:50
@sestinj
Copy link
Contributor

sestinj commented May 7, 2025

@04cfb1ed it looks like the tests are passing here on GitHub, so I'm not concerned about this. However, if you were interested in further debugging the problem I'm sure this would be useful for others trying to run local tests on the same OS as you

@sestinj sestinj merged commit a2b6328 into continuedev:main May 7, 2025
58 of 60 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Sent Headers in MCP sse server
2 participants