-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat: add support for custom headers in SSE transport #5493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for continuedev canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@04cfb1ed instead of just the "headers" field, I think we should use the full requestOptions
object that exists in index.d.ts
(it's already used for models, context providers, and more)
c4883ef
to
18832e0
Compare
The requested changes were done, but one test it's failing with ETIMEDOUT
From here #4866 (comment), I understand that the error is not from the new code (I have the same error in #5517 but in another test) |
@04cfb1ed it looks like the tests are passing here on GitHub, so I'm not concerned about this. However, if you were interested in further debugging the problem I'm sure this would be useful for others trying to run local tests on the same OS as you |
Description
Add support for custom headers in SSE transport, this allows communication with secured servers
closes #5152